Skip to content

added relation field #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlliumApotheosis wants to merge 1 commit into from
Closed

added relation field #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/models/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function NodeModelFactory (Model, waterline, _) {
},
type: {
type: 'string',
enum: [ 'compute', 'switch', 'dae', 'pdu', 'mgmt' ],
enum: [ 'compute', 'switch', 'dae', 'pdu', 'mgmt', 'enclosure'],
defaultsTo: 'compute'
},
workflows: {
Expand All @@ -50,6 +50,10 @@ function NodeModelFactory (Model, waterline, _) {
type: 'boolean',
defaultsTo: false
},
relations: {
Copy link

@larry-dean larry-dean Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to have any values such as 'encloses' and 'enclosedBy'?

Copy link
Contributor

@benbp benbp Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we make no restrictions on what you add. It all depends on which logic is using it, so feel free to put a stake in the ground as far as conventions for enclosures.

Copy link
Contributor

@benbp benbp Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unstructured json data that depends on the implementation, basically.

type: 'array',
defaultsTo: []
},
// We only count a node as having been discovered if
// a node document exists AND it has any catalogs
// associated with it
Expand Down