Skip to content

Conversation

@AlliumApotheosis
Copy link
Contributor

@benbp
Copy link
Contributor

benbp commented Oct 8, 2015

👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to have any values such as 'encloses' and 'enclosedBy'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we make no restrictions on what you add. It all depends on which logic is using it, so feel free to put a stake in the ground as far as conventions for enclosures.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unstructured json data that depends on the implementation, basically.

@anhou
Copy link
Member

anhou commented Oct 9, 2015

@VulpesArtificem As I know, @iceiilin is doing same or similar works on this. could you have a sync to avoid duplicated works?

@jfrey
Copy link
Contributor

jfrey commented Oct 9, 2015

Is there a spec for this?

@iceiilin
Copy link
Member

iceiilin commented Oct 9, 2015

@jfrey There is a story tracking this https://hwjiraprd01.corp.emc.com/browse/MAG-176, without detailed spec. I have completed it and intended to open a PR after adding PDU obm settings into enclosure node.

For that story, I created a generate-enclosure task to create enclosure info, and it is added to sku discovery workflow.

I can open a PR first about enclosure node creation.

@jfrey
Copy link
Contributor

jfrey commented Oct 9, 2015

Ok, we have some overlap here which is a concern. If @VulpesArtificem & @iceiilin can coordinate like @anhou suggested that would be great.

Suggesting we hold PR's from both of you until we are sure we have the right solution in place.

@benbp
Copy link
Contributor

benbp commented Oct 9, 2015

Yeah, as you said, looks like duplication. I suggest we just close this in favor of @iceiilin's PRs, but I would suggest keeping the defaultsTo: [] setting here. I'll add a comment to #14

dalebremner pushed a commit to dalebremner/on-core that referenced this pull request Dec 1, 2017
dalebremner pushed a commit to dalebremner/on-core that referenced this pull request Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants