[ORFS96]Get onboard SATA controller and attached disk drive data in Monorail #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onorail This is a commit depending on on-http pull Request #26 which adds SAS/SATA controller infomation into the SMART raw output. The change in this commit further decodes the newly added SMART catalog fields and appends them to the SMART catalog. Unit test code is also included
Contributor
Author
|
@RackHD/corecommitters @WangWinson @iceiilin |
Contributor
There was a problem hiding this comment.
From the implementation of "_parseControllerInfoOneDriveData", the Controller should be an object, not array, so we should initialize it to {}.
The initial value type from array to object for key 'Controller' to avoid confusion. Also modify few comments for easy read.
Contributor
|
👍 |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
benbp
added a commit
that referenced
this pull request
Oct 23, 2015
…h_onboard_disk [ORFS96]Get onboard SATA controller and attached disk drive data in Monorail
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
…113-bootstrap-rhel7-centos7 to master * commit '32d5223d0936952760eab37f8beac487d0557337': Add graph definition for RHEL 7.0 & CentOS 7.0 installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit depending on on-http pull Request #26 which adds SAS/SATA
controller infomation into the SMART raw output. The change in this commit
further decodes the newly added SMART catalog fields and appends them to
the SMART catalog.
Unit test code is also included
Dependency: on-http PR #26.