Rac 1984 redo - node/id/workflow fix after revert #613

lacarb · 2017-03-23T22:12:45Z

Follow up to this PR which used to be green but broke the pipeline when it was merged a few days later - #551

Investigating what went wrong.

JenkinsRHD · 2017-03-23T22:20:03Z

BUILD on-http #24 Error Logs ▼

Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/workflows should get a list of workflows Error Details: expected 200 "OK", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '194dfe60-9223-463d-bfe2-d5f19ecc70ae' } Error: expected 200 "OK", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 200 "OK", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)

Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/workflows should return an active workflow
Error Details: expected 200 "OK", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '38df964d-99c5-4a2a-a88a-5ebb3ae69982' } Error: expected 200 "OK", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17)
Stack Trace: Error: expected 200 "OK", got 404 "Not Found"
at Test._assertStatus (node_modules/supertest/lib/test.js:232:12)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:923:12)

yyscamper · 2017-03-27T07:51:23Z

lib/api/2.0/nodes.js

-
+    return waterline.nodes.needByIdentifier(req.swagger.params.identifier.value)
+    .then(function() {
+        return nodes.getNodeWorkflowById(req.swagger.params.identifier.value, newQuery);


nodes/getNodeworkflowById (https://github.com/RackHD/on-http/blob/master/lib/services/nodes-api-service.js#L541) doesn't support the 2nd argument newQuery, I believe this is the reason of jenkins failure.

JenkinsRHD · 2017-03-30T18:41:24Z

BUILD on-http #50 : FAILURE

BUILD on-http #50 Error Logs ▼

Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-1qRpmH03x6mmWDnkkW3O4nhtQ5Q"', 'Date': 'Thu, 30 Mar 2017 18:25:06 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"8511900e-6d49-4d85-b023-688bf18b2b82"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 284, in test_node_workflows_get
Api().nodes_get_workflow_by_id('fooey')
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 2849, in nodes_get_workflow_by_id
callback=params.get('callback'))
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-1qRpmH03x6mmWDnkkW3O4nhtQ5Q"', 'Date': 'Thu, 30 Mar 2017 18:25:06 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"8511900e-6d49-4d85-b023-688bf18b2b82"}

JenkinsRHD · 2017-03-30T19:50:41Z

BUILD on-http #51 : FAILURE

BUILD on-http #51 Error Logs ▼

Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-panO5bPvnuOzS8nqF0bb2RJpzYk"', 'Date': 'Thu, 30 Mar 2017 19:34:14 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"3e6f40f2-ef49-415e-9185-8bae96407c1e"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 284, in test_node_workflows_get
Api().nodes_get_workflow_by_id('fooey')
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 2849, in nodes_get_workflow_by_id
callback=params.get('callback'))
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-panO5bPvnuOzS8nqF0bb2RJpzYk"', 'Date': 'Thu, 30 Mar 2017 19:34:14 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"3e6f40f2-ef49-415e-9185-8bae96407c1e"}

pscharla · 2017-04-03T17:10:37Z

jenkins: test this please

JenkinsRHD · 2017-04-03T17:57:58Z

BUILD on-http #63 : FAILURE

BUILD on-http #63 Error Logs ▼

Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-EauvDmQIOs6DaKWWoSHfiz31L9c"', 'Date': 'Mon, 03 Apr 2017 17:39:26 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"aa6be32a-b30b-4644-bcc4-6379e72d9fb8"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 284, in test_node_workflows_get
Api().nodes_get_workflow_by_id('fooey')
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 2849, in nodes_get_workflow_by_id
callback=params.get('callback'))
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-EauvDmQIOs6DaKWWoSHfiz31L9c"', 'Date': 'Mon, 03 Apr 2017 17:39:26 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"aa6be32a-b30b-4644-bcc4-6379e72d9fb8"}

brianparry

@lacarb Minor change requested: remove duplicate call to waterline.nodes.needByIdentifier. Otherwise, looks good. Thanks!

brianparry · 2017-04-04T14:22:11Z

lib/api/2.0/nodes.js

-    return workflowApiService.getWorkflowsByNodeId(req.swagger.params.identifier.value,
-                                                   newQuery);
-
+    return waterline.nodes.needByIdentifier(req.swagger.params.identifier.value)


@lacarb It looks like this query is unnecessary since nodes.getNodeWorkflowById already calls waterline.nodes.needByIdentifer here: https://github.com/RackHD/on-http/blob/master/lib/services/nodes-api-service.js#L544

Nailed it. The lines have been removed

lacarb · 2017-04-04T18:45:03Z

test this please

JenkinsRHD · 2017-04-04T19:32:23Z

BUILD on-http #65 : FAILURE

BUILD on-http #65 Error Logs ▼

Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-CL+5RXnu/iYsu0ztS962u1fip70"', 'Date': 'Tue, 04 Apr 2017 19:14:10 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"9d2becd1-98a8-4f76-ac43-a85af54e7929"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 282, in test_node_workflows_get
Api().nodes_get_workflow_by_id('fooey')
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 2849, in nodes_get_workflow_by_id
callback=params.get('callback'))
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-CL+5RXnu/iYsu0ztS962u1fip70"', 'Date': 'Tue, 04 Apr 2017 19:14:10 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"9d2becd1-98a8-4f76-ac43-a85af54e7929"}

pscharla · 2017-04-07T20:13:32Z

jenkins: test this please

JenkinsRHD · 2017-04-07T20:32:49Z

BUILD on-http #77 : FAILURE

DavidjohnBlodgett · 2017-04-07T21:21:54Z

👍 post jenkins testing resulting in green... and I assume your concerns have been addressed @brianparry ?

lacarb · 2017-04-07T21:23:57Z

They were, he was right about the removal of some redundant lines.

JenkinsRHD · 2017-04-07T21:38:28Z

BUILD on-http #80 : FAILURE

BUILD on-http #80 Error Logs ▼

Test Name: test_node_workflows_post Error Details: local variable 'data' referenced before assignment -------------------- >> begin captured logging << -------------------- tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=20) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=19) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=18) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=17) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=16) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=15) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=14) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=13) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=12) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=11) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=10) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=9) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=8) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=7) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=6) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=5) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=4) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=3) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=2) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=1) --------------------- >> end captured logging << --------------------- Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 303, in test_node_workflows_post resps.append({'data': data, 'id':id}) "local variable 'data' referenced before assignment\n-------------------- >> begin captured logging << --------------------\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=20)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=19)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=18)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=17)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=16)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=15)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=14)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=13)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=12)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=11)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=10)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=9)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=8)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=7)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=6)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=5)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=4)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=3)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=2)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58e802902172dac00a213e36 (status=succeeded,timeout=1)\n--------------------- >> end captured logging << ---------------------"

lacarb · 2017-04-11T17:56:34Z

test this please

JenkinsRHD · 2017-04-11T18:39:19Z

BUILD on-http #90 : FAILURE

BUILD on-http #90 Error Logs ▼

Test Name: test_workflows_action Error Details: Timed out waiting for graph to start! -------------------- >> begin captured logging << -------------------- tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=20) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=19) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=18) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=17) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=16) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=15) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=14) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=13) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=12) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=11) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=10) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=9) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=8) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=7) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=6) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=5) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=4) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=3) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=2) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=1) --------------------- >> end captured logging << --------------------- Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 321, in test_workflows_action fail('Timed out waiting for graph to start!') File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/asserts.py", line 220, in fail raise ASSERTION_ERROR(message) 'Timed out waiting for graph to start!\n-------------------- >> begin captured logging << --------------------\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=20)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=19)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=18)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=17)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=16)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=15)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=14)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=13)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=12)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=11)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=10)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=9)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=8)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=7)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=6)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=5)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=4)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=3)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=2)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58ed1e9915359dbb0a447dfe (status=succeeded,timeout=1)\n--------------------- >> end captured logging << ---------------------'

PengTian0 · 2017-04-13T05:20:46Z

test this please

lacarb · 2017-04-13T23:14:51Z

test this please

pscharla · 2017-04-14T16:58:26Z

jenkins: test this please

JenkinsRHD · 2017-04-14T17:05:11Z

BUILD on-http #96 : FAILURE

BUILD on-http #96 Error Logs ▼

Test Name: Http.Api.Tasks GET /tasks/:id should return 404 if no active task exists Error Details: expected 404 "Not Found", got 500 "Internal Server Error" Response body: { message: '/home/jenkins/workspace/on-http/build-deps/on-http/data/views:2 1| { >> 2| "identifier": "<%= identifier %>", 3| <% if (hasOwnProperty("exit")) { %> 4| "exit": "<%= exit %>", 5| <% } %> identifier is not defined', status: '500', UUID: '75d25b6f-3fb2-4649-9964-75cae29aad7b' } Error: expected 404 "Not Found", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 404 "Not Found", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)

lacarb · 2017-04-14T17:15:06Z

test this please

lacarb · 2017-04-14T18:15:28Z

@brianparry, how's it look?

DavidjohnBlodgett · 2017-04-14T18:17:12Z

👍 but please squash the commits before merging, and make sure the resulting commit message has the RAC number too! Thanks.

JenkinsRHD · 2017-04-14T19:38:45Z

BUILD on-http #98 : FAILURE

lacarb · 2017-04-14T20:01:57Z

test this please

yyscamper reviewed Mar 27, 2017

View reviewed changes

lacarb force-pushed the RAC-1984-redo branch from e6f3da1 to 9bcf4b4 Compare March 30, 2017 17:54

lacarb force-pushed the RAC-1984-redo branch from 9bcf4b4 to ccadf87 Compare March 30, 2017 19:08

This was referenced Apr 3, 2017

Rac 1984 cit test fixme RackHD/RackHD#694

Closed

Rac 1984 cit test removal RackHD/RackHD#695

Closed

Temporary removal of CIT test blocking an API fix RackHD/RackHD#696

Merged

brianparry suggested changes Apr 4, 2017

View reviewed changes

This was referenced Apr 6, 2017

Rac 1984 cit test fix2 RackHD/RackHD#701

Closed

Correction for CIT test modification. RackHD/RackHD#705

Merged

lacarb force-pushed the RAC-1984-redo branch from ccadf87 to 3711db3 Compare April 7, 2017 20:54

lacarb mentioned this pull request Apr 8, 2017

RAC-1984 (somewhat) Removal of node/:id/workflows POST CIT test RackHD/RackHD#707

Merged

lacarb mentioned this pull request Apr 11, 2017

RAC-1984 (somewhat) Removal of PUT node/id/workflows CIT test RackHD/RackHD#712

Merged

Correction for id/workflows. General linting

b3d443b

lacarb force-pushed the RAC-1984-redo branch from 01f82b6 to b3d443b Compare April 14, 2017 18:50

brianparry approved these changes Apr 14, 2017

View reviewed changes

AlliumApotheosis approved these changes Apr 14, 2017

View reviewed changes

AlliumApotheosis merged commit 2702785 into RackHD:master Apr 14, 2017

JenkinsRHD mentioned this pull request Oct 2, 2017

Remove the SB routes from on-http #793

Merged

Rac 1984 redo - node/id/workflow fix after revert #613

Rac 1984 redo - node/id/workflow fix after revert #613

Uh oh!

Conversation

lacarb commented Mar 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JenkinsRHD commented Mar 23, 2017

Uh oh!

yyscamper Mar 27, 2017

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Mar 30, 2017

Uh oh!

JenkinsRHD commented Mar 30, 2017

Uh oh!

pscharla commented Apr 3, 2017

Uh oh!

JenkinsRHD commented Apr 3, 2017

Uh oh!

brianparry left a comment

Choose a reason for hiding this comment

Uh oh!

brianparry Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

lacarb Apr 7, 2017

Choose a reason for hiding this comment

Uh oh!

lacarb commented Apr 4, 2017

Uh oh!

JenkinsRHD commented Apr 4, 2017

Uh oh!

pscharla commented Apr 7, 2017

Uh oh!

JenkinsRHD commented Apr 7, 2017

Uh oh!

DavidjohnBlodgett commented Apr 7, 2017

Uh oh!

lacarb commented Apr 7, 2017

Uh oh!

JenkinsRHD commented Apr 7, 2017

Uh oh!

lacarb commented Apr 11, 2017

Uh oh!

JenkinsRHD commented Apr 11, 2017

Uh oh!

PengTian0 commented Apr 13, 2017

Uh oh!

lacarb commented Apr 13, 2017

Uh oh!

pscharla commented Apr 14, 2017

Uh oh!

JenkinsRHD commented Apr 14, 2017

Uh oh!

lacarb commented Apr 14, 2017

Uh oh!

lacarb commented Apr 14, 2017

Uh oh!

DavidjohnBlodgett commented Apr 14, 2017

Uh oh!

JenkinsRHD commented Apr 14, 2017

Uh oh!

lacarb commented Apr 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lacarb commented Mar 23, 2017 •

edited

Loading