Rac 1984 node/id/workflow returns appropriate response codes #551
Conversation
|
BUILD on-http #3012 : UNSTABLE
BUILD unit-tests #10713 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/workflows should get a list of workflows Error Details: expected 200 "OK", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '9bcef78c-2d2d-4ed1-a769-83641858e0a7' } Error: expected 200 "OK", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 200 "OK", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/workflows should return an active workflow BUILD smoke-test #4070 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-G2AHXxv+mP+bTkpRYz0QBg"', 'Date': 'Thu, 05 Jan 2017 20:06:41 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"c5b5384a-7c5f-4397-a5b1-5c13bb9a4e54"}-------------------- >> begin captured logging << -------------------- |
|
BUILD on-http #3013 : UNSTABLE
BUILD smoke-test #4071 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-ZEsRGxTheaYJIRuQrsxryA"', 'Date': 'Thu, 05 Jan 2017 20:32:56 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"eab7bfe8-fe82-4d89-a724-020c93ecb343"}-------------------- >> begin captured logging << -------------------- |
|
test this please |
lib/api/2.0/nodes.js
Outdated
| var nodes = injector.get('Http.Services.Api.Nodes'); | ||
| var waterline = injector.get('Services.Waterline'); | ||
| var workflowApiService = injector.get('Http.Services.Api.Workflows'); | ||
| //var workflowApiService = injector.get('Http.Services.Api.Workflows'); |
There was a problem hiding this comment.
Please directly remove this.
|
BUILD on-http #3030 : ABORTED |
|
test this please |
|
BUILD on-http #3032 : FAILURE
BUILD CIT #196 Error Logs ▼Test Name: test09_check_discovery Error Details: Node discovery not completed -------------------- >> begin captured stdout << --------------------- **** Waiting for node Discovery to complete.--------------------- >> end captured stdout << ---------------------- Test Name: test10_apply_obm_settings --------------------- >> end captured stdout << ---------------------- Test Name: test12_check_pollers --------------------- >> end captured stdout << ---------------------- BUILD FIT #168 Error Logs ▼Test Name: test09_check_discovery Error Details: Node discovery not completed -------------------- >> begin captured stdout << --------------------- **** Waiting for node Discovery to complete.--------------------- >> end captured stdout << ---------------------- BUILD SmokeTest-FIT #36 Error Logs ▼Test Name: test09_check_discovery Error Details: Node discovery not completed -------------------- >> begin captured stdout << --------------------- **** Waiting for node Discovery to complete.--------------------- >> end captured stdout << ---------------------- Test Name: test10_apply_obm_settings --------------------- >> end captured stdout << ---------------------- Test Name: test12_check_pollers --------------------- >> end captured stdout << ---------------------- Test Name: test09_check_discovery --------------------- >> end captured stdout << ---------------------- |
|
test this please |
|
BUILD on-http #3033 : ABORTED |
|
test this please |
| }); | ||
|
|
||
| var nodesGetWorkflowById = controller(function(req) { | ||
| var newQuery; |
There was a problem hiding this comment.
Removing this code breaks the ?active=true and ?active=false query parameters. These were explicitly changed from the /active endpoint in the 1.1 API because, at the time, there was some confusion about the semantics. Adding the query makes things more explicit.
brianparry
left a comment
brianparry
left a comment
There was a problem hiding this comment.
I think all that you need to do is restore all of the query code and modify nodes.getNodeWorkflowById to take a query and merge it into the graphobjects query. Essentially merge the workflows service method with the nodes service method.
lib/api/2.0/nodes.js
Outdated
| return workflowApiService.getWorkflowsByNodeId(req.swagger.params.identifier.value, | ||
| newQuery); | ||
|
|
||
| return nodes.getNodeWorkflowById(req.swagger.params.identifier.raw); |
There was a problem hiding this comment.
The nodes service can be used here in place of the workflow service, but it needs to be modified to accept a query. Otherwise, this is an API breaking change. As far as I can tell, the only thing that's actually needed to fix this bug is a call to waterline.nodes.needByIdentifier prior to the graphobjects query.
|
BUILD on-http #3048 : UNSTABLE
BUILD CIT #273 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-ZAAH3bwhF+uCkbOz8H6LgA"', 'Date': 'Tue, 10 Jan 2017 20:58:53 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"e3fc331f-c7de-48f0-9f45-746d4c15c5f0"}Stack Trace: Traceback (most recent call last): BUILD SmokeTest-FIT #61 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-ZAAH3bwhF+uCkbOz8H6LgA"', 'Date': 'Tue, 10 Jan 2017 20:58:53 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"e3fc331f-c7de-48f0-9f45-746d4c15c5f0"}Stack Trace: Traceback (most recent call last): |
|
BUILD on-http #3096 : UNSTABLE
BUILD CIT #497 Error Logs ▼Test Name: test_node_workflows_get Error Details: Should be empty Stack Trace: Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 296, in test_node_workflows_get assert_equal(len(resps_fooey), 0, message='Should be empty') File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal raise ASSERTION_ERROR(message) AssertionError: Should be emptyBUILD SmokeTest-FIT #133 Error Logs ▼Test Name: test_node_workflows_get Error Details: Should be empty Stack Trace: Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 296, in test_node_workflows_get assert_equal(len(resps_fooey), 0, message='Should be empty') File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal raise ASSERTION_ERROR(message) AssertionError: Should be empty |
|
test this please |
|
BUILD on-http #3104 : UNSTABLE
BUILD CIT #524 Error Logs ▼Test Name: test_node_workflows_get Error Details: Should be empty Stack Trace: Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 296, in test_node_workflows_get assert_equal(len(resps_fooey), 0, message='Should be empty') File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal raise ASSERTION_ERROR(message) AssertionError: Should be emptyBUILD SmokeTest-FIT #143 Error Logs ▼Test Name: test_node_workflows_get Error Details: Should be empty Stack Trace: Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 296, in test_node_workflows_get assert_equal(len(resps_fooey), 0, message='Should be empty') File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal raise ASSERTION_ERROR(message) AssertionError: Should be empty |
lib/api/2.0/nodes.js
Outdated
| return workflowApiService.getWorkflowsByNodeId(req.swagger.params.identifier.value, | ||
| newQuery); | ||
|
|
||
| return nodes.getNodeWorkflowById(req.swagger.params.identifier.value.newQuery); |
There was a problem hiding this comment.
@lacarb I think this is a typo. Shouldn't this be req.swagger.params.identifier.value, newQuery rather than req.swagger.params.identifier.value.newQuery?
|
BUILD on-http #3128 : UNSTABLE
BUILD CIT #619 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-/HN1f9XXIKsx3f1kk28ZQg"', 'Date': 'Fri, 20 Jan 2017 22:43:18 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"75572763-79ae-45c3-85bf-9ff7f0b3ecb4"}Stack Trace: Traceback (most recent call last): BUILD SmokeTest-FIT #179 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-/HN1f9XXIKsx3f1kk28ZQg"', 'Date': 'Fri, 20 Jan 2017 22:43:18 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"75572763-79ae-45c3-85bf-9ff7f0b3ecb4"}Stack Trace: Traceback (most recent call last): |
|
There is a single CIT test that is failing. It fails because it was made based on the old implementation of this command. |
|
test this please |
|
BUILD on-http #3237 : FAILURE
|
|
BUILD on-http #3241 : ABORTED
|
|
BUILD on-http #3243 : UNSTABLE
BUILD unit-tests #11625 Error Logs ▼Test Name: Http.Api.Profiles "before each" hook: set up mocks for "should send a 500 if profileApiService.getNode fails" Error Details: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test. Stack Trace: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.Test Name: Http.Api.Lookup "before all" hook: start HTTP server |
|
BUILD on-http #3244 : UNSTABLE
BUILD unit-tests #11626 Error Logs ▼Test Name: Redfish Registries "before all" hook: start HTTP server Error Details: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test. Stack Trace: Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.Test Name: Redfish Schemas "before all" hook: start HTTP server Test Name: Redfish TaskService "before all" hook: start HTTP server Test Name: Http.Api.Skus "before all" hook: start HTTP server Test Name: Http.Api.Nodes v1.1 "before all" hook: start HTTP server Test Name: Http.Api.Tags "before all" hook: start HTTP server Test Name: Http.Api.Schemas "before all" hook: start HTTP server Test Name: Http.Api.Tasks "before all" hook: start HTTP server Test Name: Http.Api.Files "before all" hook: start HTTP server Test Name: Http.Api.Notification "before all" hook: start HTTP server |
|
test this please |
|
BUILD on-http #3293 : UNSTABLE
BUILD SmokeTest-CIT #675 Error Logs ▼Test Name: test_node_workflows_post Error Details: local variable 'data' referenced before assignment -------------------- >> begin captured logging << -------------------- tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=20) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=19) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=18) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=17) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=16) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=15) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=14) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=13) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=12) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=11) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=10) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=9) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=8) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=7) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=6) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=5) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=4) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=3) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=2) tests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=1) --------------------- >> end captured logging << --------------------- Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/Templates/SmokeTest-CIT/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/Templates/SmokeTest-CIT/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/Templates/SmokeTest-CIT/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/Templates/SmokeTest-CIT/RackHD/test/tests/api/v2_0/nodes_tests.py", line 299, in test_node_workflows_post resps.append({'data': data, 'id':id}) "local variable 'data' referenced before assignment\n-------------------- >> begin captured logging << --------------------\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=20)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=19)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=18)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=17)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=16)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=15)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=14)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=13)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=12)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=11)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=10)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=9)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=8)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=7)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=6)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=5)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=4)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=3)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=2)\ntests.api.v2_0.nodes_tests: WARNING: Workflow status for Node 58a5fb3e545ca22e08113360 (status=succeeded,timeout=1)\n--------------------- >> end captured logging << ---------------------" |
|
test this please |
|
BUILD on-http #3444 : UNSTABLE
BUILD SmokeTest-CIT #1499 Error Logs ▼Test Name: test_node_workflows_get Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '116', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"74-WGkSCH2N9+YPCyU5CsN+7o3KFVQ"', 'Date': 'Wed, 08 Mar 2017 00:34:53 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"Could not find node with identifier fooey","status":"404","UUID":"2aedf524-afac-4231-8228-4f616529d143"}Stack Trace: Traceback (most recent call last): |
|
test this please |
|
@brianparry, we're green on Jenkins due to another PR I got through. Can this be merged or do you still have feedback? Thanks! |
|
@yyscamper or @brianparry : Can you merge this one for us? |
|
@lacarb this PRs break CI test, and it seems not only one place need to be updated in test, I'll revert it temperally to let CI pass. |
8 participants
The 2.0 api for node/{identifier}/workflows presently returns an empty array and 200 no matter what it is passed.
The proposed solution is taken from 1.1 which rejects bad identifiers
and responds with the workflows run against a node if the ID matches.
The method
WorkflowApiService.prototype.getWorkflowsByNodeIdwas deleted because it was only used once in the 2.0 method which never worked as intended.