Add 2.0 API pollers routes #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GET /pollers/library
* GET /pollers/library/{identifier}
* GET /pollers
* GET /pollers/{identifier}
* POST /pollers
* PATCH /pollers/{identifier}
* DELETE /pollers/{identifier}
* PATCH /pollers/{identifier}/pause
* PATCH /pollers/{identifier}/resume
* GET /pollers/{identifier}/data
* GET /pollers/{identifier}/data/current
| body: mockData | ||
| }; | ||
| var res = {}; | ||
| var mockError = new Error('deserializer error'); |
Contributor
Author
|
Coverage should improve when @srinia6 submits her PR with unit tests. |
Contributor
Author
|
@RackHD/corecommitters @geoff-reid @srinia6 @dalebremner @abildw |
Contributor
|
@brianparry Will there be any functional tests created for these new APIs? |
Contributor
Author
|
@jlongever Yes. We're planning to start creating functional tests for all of the 2.0 routes soon. We added some test stories to our backlog on Friday. I expect we will start working on them next sprint. |
| @@ -0,0 +1,79 @@ | |||
| // Copyright 2015, EMC, Inc. | |||
Contributor
There was a problem hiding this comment.
created on 2015 or 2016 ?
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
| body: mockData | ||
| }; | ||
| var res = {}; | ||
| var mockError = new Error('deserializer error'); |
srinia6
force-pushed
the
feature/swagger-pollers-route
branch
from
acb31b4 to
6307b77
Compare
Contributor
|
Contributor
|
Contributor
|
test this please |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes the following methods/routes. @srinia6 will be submitting a follow-on PR with unit tests for these routes.