-
Notifications
You must be signed in to change notification settings - Fork 77
Change /schemas/tasks API implementation according to new task schema design #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BUILD on-http #35 : FAILURE BUILD on-http #35 Error Logs ▼Test Name: Http.Api.Schemas GET /schemas/tasks should return a list of all task schemas Error Details: expected [] to have a length of 2 but got 0 Response body: [] AssertionError: expected [] to have a length of 2 but got 0 at originalMethod (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/chai-as-promised/lib/chai-as-promised.js:276:69) at doAsserterAsyncAndAddThen (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/chai-as-promised/lib/chai-as-promised.js:298:33) at Assertion.addChainableMethod.originalGetter (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/chai-as-promised/lib/chai-as-promised.js:278:25) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/chai/lib/chai/utils/addChainableMethod.js:83:49) at /home/jenkins/workspace/on-http/build-deps/on-http/spec/lib/api/2.0/schemas-spec.js:120:61 at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:691:12) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: AssertionError: expected [] to have a length of 2 but got 0 at originalMethod (node_modules/chai-as-promised/lib/chai-as-promised.js:276:69) at doAsserterAsyncAndAddThen (node_modules/chai-as-promised/lib/chai-as-promised.js:298:33) at Assertion.addChainableMethod.originalGetter (node_modules/chai-as-promised/lib/chai-as-promised.js:278:25) at assert (node_modules/chai/lib/chai/utils/addChainableMethod.js:83:49) at spec/lib/api/2.0/schemas-spec.js:120:61 at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:691:12) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)Test Name: Http.Api.Schemas GET /schemas/tasks/:identifier should return a task schema Test Name: Http.Api.Schemas GET /schemas/tasks/:identifier should return a task schema with reference resolved |
… design - The task schema identifier is changed to use task's injectableName rather than filename, since the built-in schema doesn't have a filename - GET /schemas/tasks will return the list of task injectableNames - The `resolved` flag is removed in GET /schemas/tasks/:identifier since now the returned schema is always resolved. The unresolved version doesn't conform to the JSON schema standard, so it is removed.
7a41066 to
5d14501
Compare
|
BUILD on-http #37 : FAILURE BUILD on-http #37 Error Logs ▼Test Name: test09_check_discovery Error Details: Node discovery not completed -------------------- >> begin captured stdout << --------------------- restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Status code = 200restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78788baa51a50aa74330/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78788baa51a50aa74330/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c/workflows --------------------- >> end captured stdout << ---------------------- --------------------- >> end captured logging << --------------------- Test Name: test10_apply_obm_settings restful: Action = put , URL = http://localhost:9090/api/2.0/workflows/graphs restful: Action = put , URL = http://localhost:9090/api/2.0/workflows/graphs restful: Action = put , URL = http://localhost:9090/api/2.0/workflows/graphs restful: Action = get , URL = http://localhost:9090/api/2.0/skus restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78788baa51a50aa74330 restful: Action = get , URL = http://localhost:9090/api/2.0/skus/0dce80c1-e976-497b-a419-1e1c89c6f31e restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78788baa51a50aa74330 restful: Action = get , URL = http://localhost:9090/api/2.0/skus/0dce80c1-e976-497b-a419-1e1c89c6f31e restful: Action = post , URL = http://localhost:9090/api/2.0/nodes/58db78788baa51a50aa74330/workflows restful: Action = get , URL = http://localhost:9090/api/2.0/workflows/9b0e6154-97d1-42fd-93b3-b57cf83ac36a restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/workflows/9b0e6154-97d1-42fd-93b3-b57cf83ac36a **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/workflows/9b0e6154-97d1-42fd-93b3-b57cf83ac36a restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: restful: Action = get , URL = http://localhost:9090/api/2.0/nodes restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db787c8baa51a50aa7433c restful: Action = get , URL = http://localhost:9090/api/2.0/nodes/58db78808baa51a50aa74348 **** Node(s) OBM status: --------------------- >> end captured stdout << ---------------------- |
|
jenkins: test this please |
| }); | ||
| }); | ||
|
|
||
| // GET /api/2.0/schemas/tasks/:identifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:name should be more accurate than :identifier.
| var taskSchemasGet = controller(function () { | ||
| return taskOptionValidator.getAllSchemaNames({ includeNameSpace: false }); | ||
| return workflowApiService.getTaskDefinitions() | ||
| .then(function(tasks) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yyscamper FYI - Bluebird promises have a chaiable map method: http://bluebirdjs.com/docs/api/promise.map.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The promise that returned from getTaskDefinition is not bluebird style promise, it is waterline's promise, it doesn't have a map function, so that's the reason I ended up using the array's map.
Now in RackHD code there is various Promise (at least there are Bluebird promise, node.js native promise, waterline promise), we'd better to combine them to a single one in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yyscamper I like to wrap promise returning function calls in Promise.try for this reason. This normalizes promises to Bluebird style. It also will handle any synchronous errors that might be thrown by a promise returning function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Promise.try as well, it changes a lot of things (synchronous code or erros, non-bluebird promises) into bluebird promise, though a little cumbersome sometimes.
brianparry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
test this please |
|
jenkins: test this please |
Changelog:
The task schema identifier is changed to use task's injectableName rather than filename, since the built-in schema doesn't have a filename
GET /schemas/tasks will return the list of task injectableNames
The
resolvedflag is removed in GET /schemas/tasks/:identifier since now the returned schema is always resolved. The unresolved version doesn't conform to the JSON schema standard, so it is removed.@anhou @iceiilin @pengz1 @lanchongyizu @brianparry