Fix-notification-progress-data-pre-validation-error #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
BUILD on-http #111 : FAILURE BUILD on-http #111 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 404 if no active task exists Error Details: expected 404 "Not Found", got 500 "Internal Server Error" Response body: { message: '/home/jenkins/workspace/on-http/build-deps/on-http/data/views:2 1| { >> 2| "identifier": "<%= identifier %>", 3| <% if (hasOwnProperty("exit")) { %> 4| "exit": "<%= exit %>", 5| <% } %> identifier is not defined', status: '500', UUID: 'dad0d04c-54ab-40de-94ab-969578d39a92' } Error: expected 404 "Not Found", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 404 "Not Found", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12) |
* Existing progress data pre-validation will reject 0 value * Enhance progress data pre-validation and pack them in a Promise.try
yyscamper
reviewed
Apr 21, 2017
| .expect(400); | ||
| }); | ||
|
|
||
| it('should return 400 if maximum is invalid in body', function() { |
yyscamper
approved these changes
Apr 21, 2017
Contributor
yyscamper
left a comment
yyscamper
left a comment
There was a problem hiding this comment.
+1 after fixing the comment
pengz1
force-pushed
the
Fix-notification-progress-data-pre-validation-error
branch
from
fc76ece to
5da6e15
Compare
iceiilin
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing progress data pre-validation will reject 0 value, this is not expected.
This PR enhances progress data pre-validation and pack them in a Promise.try.
Also negative and boundary tests are added.