Toggle error view stack trace based on minLogLevel #414
Conversation
|
nice add @dalebremner, I like the pattern. Might be worth a mention explicitly in the docs as well - maybe a little tweak/additional letting folks know about this upcoming side effect at https://github.com/RackHD/docs/blame/master/docs/rackhd/configuration.rst#L167 |
|
👍 |
|
will do @heckj |
lib/fittings/error_handler.js
Outdated
| module.exports = function create() { | ||
| var injector = require('../../index.js').injector; | ||
| var swaggerService = injector.get('Http.Services.Swagger'); | ||
| var nconf = injector.get('nconf'); |
There was a problem hiding this comment.
You should use the Services.Configuration dependency here instead of nconf directly.
|
👍 |
|
👍 |
|
👍 though I agree with @anhou and @yyscamper that we probably don't need/want to return stack traces through the API at all, but rather if debugging you can look them up in logs instead. That said, on a separate note, maybe it would be a good idea for us to start keeping track of unique request IDs and returning those, so if someone gets a 500 error, we have a unique ID to search the logs with to find the exact message that corresponds to the problematic request? @RackHD/corecommitters @heckj |
7 participants
@RackHD/corecommitters @keedya @BillyAbildgaard @srinia6