return empty object when access api without token or with error token #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
Contributor
Author
lanchongyizu
reviewed
Nov 4, 2016
lib/services/auth-service.js
Outdated
| } | ||
| else if (!user){ | ||
| res.status(UNAUTHORIZED_STATUS).send({message: challenges.message}); | ||
| res.status(UNAUTHORIZED_STATUS).send({message: challenges[0].message}); |
Member
There was a problem hiding this comment.
We should check all challenges and return all error messages, not just the first one. Maybe the first one is a successful message.
Contributor
Author
There was a problem hiding this comment.
Thanks for your catching!
I will fix that.
Member
|
👍 after fix houndci problems. |
Contributor
Author
|
Jenkins: test this please |
yyscamper
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to access API without token or with a wrong token and just got an empty object.
Cause:
The returned info object is a list.
But the code uses it as a dictionary which contains "message".