RAC-3801 ESXi 6.0 OS installation failure when network interface is s… #547

manfrednde · 2017-01-03T17:37:40Z

…et to dhcp

This code change is to solve the issue where the network interface is specified in the payload and it is set to dhcp. The payload may look like the following in this case:

{
"options": {
"defaults": {
"version": "6.0",
"repo": "http://172.31.128.1:9080/esxi/esxi6",
"networkDevices":[{"device": "vmnic2"}]
}
}
}
It looks like when the host try to download the call back script the link is not ready. So I included a retry option in the kickstart script.

@RackHD/corecommitters

@stuart-stanley

@derrickostertag

@johren

…et to dhcp

manfrednde · 2017-01-03T17:40:43Z

@jimturnquist

jimturnquist · 2017-01-03T20:57:44Z

data/templates/esx-ks

+#
+# Try to download call back script 60 times 1 second
+# sleep in between to allow link to be up after DHCP
+for retry in $(awk 'BEGIN { for ( i=0; i<60; i++ ) { print i; } }');


This iteration technique seems overly complex. How about:

for retry in $(seq 1 60); do
...
...
done

So, the question is if busy box supports the above iteration pattern. I will check...

I just ran under busy box and the iteration form above worked fine.

Busy box v1.21.1

If you want to test run your sample commands:

turnqj1@lab03:~$ busybox sh

BusyBox v1.21.1 (Ubuntu 1:1.21.0-1ubuntu1) built-in shell (ash)
Enter 'help' for a list of built-in commands.

/emc/turnqj1 $

Ok I will try your suggestions

…et to dhcp

manfrednde

@jimturnquist

manfrednde · 2017-01-03T21:21:29Z

data/templates/esx-ks

+#
+# Try to download call back script 60 times 1 second
+# sleep in between to allow link to be up after DHCP
+for retry in $(awk 'BEGIN { for ( i=0; i<60; i++ ) { print i; } }');


Ok I will try your suggestions

…et to dhcp

yyscamper · 2017-01-04T03:58:36Z

@manfrednde change logger to echo is better for me as well. Do you have ever tried if on-syslog is down, whether the logger command will fail and continue to fail the whole installation?

Meanwhile, I'd suggest you use the -p to specify the logger level, so that user not feel it is a bug while seeing "Failed to download call back script after 1 attempt"

-p, --priority priority
              Enter the message into the log with the specified priority.  The priority may be specified numerically or as a facility.level pair.  For example, -p local3.info logs the message
              as informational in the local3 facility.  The default is user.notice.

…et dhcp

manfrednde · 2017-01-04T21:33:27Z

@yyscamper
@jimturnquist

Please review above change

jimturnquist · 2017-01-04T21:44:18Z

Could we catch the case where the retries were exhausted and report via user.err? Something like:

if [ $retry -eq 60 ]; then
logger -p user.err "Failed to download RackHD's call back script, kickstart failed"
fi

manfrednde · 2017-01-04T22:14:10Z

Thanks Jim I will add that case but executing the kickstart file will not fail

…et to dhcp

manfrednde · 2017-01-04T22:54:08Z

@jimturnquist
@yyscamper
Please review new change

jimturnquist · 2017-01-05T03:07:05Z

data/templates/esx-ks

+    else
+        logger -p user.info "Failed to download RackHD's call back script after $retry attempt(s)."
+        sleep 1
+        if [ $retry -eq 60 ]; then


You should be able to just check it once after the loop is finished instead of every iteration.

…et to dhcp

manfrednde · 2017-01-05T15:15:03Z

@jimturnquist
@yyscamper

JenkinsRHD · 2017-01-05T16:27:07Z

BUILD on-http #3009 : UNSTABLE

** BUILD build-config-setup #505: SUCCESS
** BUILD unit-tests #10710: SUCCESS
** BUILD smoke-test #4067: UNSTABLE

BUILD smoke-test #4067 Error Logs ▼

Test Name: test_sel_overflow Error Details: 'SEL Record ID' -------------------- >> begin captured logging << -------------------- root: INFO: +186+186+186+186+186 root: INFO: -------STARTING TEST: proboscis.case.MethodTest (test_sel_overflow)-------- root: INFO: +186+186+186+186+186 --------------------- >> end captured logging << --------------------- Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/on-http/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/sel_alert_poller_tests.py", line 162, in test_sel_overflow LOG.info(selInfoObj["SEL Record ID"][0]) "'SEL Record ID'\n-------------------- >> begin captured logging << --------------------\nroot: INFO: +186+186+186+186+186\nroot: INFO: -------STARTING TEST: proboscis.case.MethodTest (test_sel_overflow)--------\nroot: INFO: +186+186+186+186+186\n--------------------- >> end captured logging << ---------------------"

PengTian0 · 2017-01-06T10:56:04Z

test this please

manfrednde · 2017-01-10T16:03:13Z

@johren

Can you please check the above changes and merge if all good ?

Thank you
Manfred

brianparry

👍

RAC-3801 ESXi 6.0 OS installation failure when network interface is s…

09221bb

…et to dhcp

jimturnquist reviewed Jan 3, 2017

View reviewed changes

RAC-3801 ESXi 6.0 OS installation failure when network interface is s…

e8326e4

…et to dhcp

manfrednde commented Jan 3, 2017

View reviewed changes

RAC-3801 ESXi 6.0 OS installation failure when network interface is s…

46a9e80

…et to dhcp

RAC-3801 ESXi 6.0 OS installation failure when network interface is s…

3d01295

…et dhcp

RAC-3801 ESXi 6.0 OS installation failure when network interface is s…

5156ee5

…et to dhcp

jimturnquist reviewed Jan 5, 2017

View reviewed changes

RAC-3801 ESXi 6.0 OS installation failure when network interface is s…

8f377f1

…et to dhcp

yyscamper approved these changes Jan 9, 2017

View reviewed changes

brianparry approved these changes Jan 10, 2017

View reviewed changes

brianparry merged commit ad03599 into RackHD:master Jan 10, 2017

JenkinsRHD mentioned this pull request Sep 21, 2017

TESTING PR #783

Closed

RAC-3801 ESXi 6.0 OS installation failure when network interface is s… #547

RAC-3801 ESXi 6.0 OS installation failure when network interface is s… #547

Uh oh!

Conversation

manfrednde commented Jan 3, 2017

Uh oh!

manfrednde commented Jan 3, 2017

Uh oh!

jimturnquist Jan 3, 2017

Choose a reason for hiding this comment

Uh oh!

jimturnquist Jan 3, 2017

Choose a reason for hiding this comment

Uh oh!

jimturnquist Jan 3, 2017

Choose a reason for hiding this comment

Uh oh!

jimturnquist Jan 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manfrednde Jan 3, 2017

Choose a reason for hiding this comment

Uh oh!

manfrednde left a comment

Choose a reason for hiding this comment

Uh oh!

manfrednde Jan 3, 2017

Choose a reason for hiding this comment

Uh oh!

yyscamper commented Jan 4, 2017

Uh oh!

manfrednde commented Jan 4, 2017

Uh oh!

jimturnquist commented Jan 4, 2017

Uh oh!

manfrednde commented Jan 4, 2017

Uh oh!

manfrednde commented Jan 4, 2017

Uh oh!

jimturnquist Jan 5, 2017

Choose a reason for hiding this comment

Uh oh!

manfrednde commented Jan 5, 2017

Uh oh!

JenkinsRHD commented Jan 5, 2017

Uh oh!

PengTian0 commented Jan 6, 2017

Uh oh!

manfrednde commented Jan 10, 2017

Uh oh!

brianparry left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jimturnquist Jan 3, 2017 •

edited

Loading