-
Notifications
You must be signed in to change notification settings - Fork 77
Graph config #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph config #543
Conversation
yyscamper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to add the doc for this new config parameter: http://rackhd.readthedocs.io/en/latest/rackhd/configuration.html#configuration-parameters
|
@VulpesArtificem please also submit a PR for docs @yyscamper mentioned at the same time to avoid forgetting it in the near future. |
brianparry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@VulpesArtificem ready to merge, just need to resolve the conflicts |
95d9897 to
91d5e00
Compare
|
BUILD on-http #2997 : UNSTABLE
BUILD unit-tests #10683 Error Logs ▼Test Name: Http.Services.Api.Profiles should run discovery with the configuration given graph Error Details: expected createAndRunGraph to have been called with arguments { name: "from.config.graph", options: { defaults: { graphOptions: { target: "test" }, nodeId: "test" } } } createAndRunGraph({ name: "from.config.graph", options: { defaults: { graphOptions: { obm-option: { autoCreateObm: "from.config.graph" }, target: "test" }, nodeId: "test" } } }, null) => [object Promise] at ProfileApiService.runDiscovery (/home/jenkins/workspace/on-http/build/lib/services/profiles-api-service.js:9:6635) Stack Trace: AssertionError: expected createAndRunGraph to have been called with arguments { name: "from.config.graph", options: { defaults: { graphOptions: { target: "test" }, nodeId: "test" } } } createAndRunGraph({ name: "from.config.graph", options: { defaults: { graphOptions: { obm-option: { autoCreateObm: "from.config.graph" }, target: "test" }, nodeId: "test" } } }, null) => [object Promise] at ProfileApiService.runDiscovery (lib/services/profiles-api-service.js:9:6635) at spec/lib/services/profiles-api-service-spec.js:237:71 at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23) at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31) at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18) at Promise._settlePromises (node_modules/on-core/node_modules/bluebird/js/main/promise.js:700:14) at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:123:16) at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10) at Immediate.Async.drainQueues [as _onImmediate] (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14) |
91d5e00 to
7567545
Compare
RAC-2020 Provide capability to run configurable discovery workflow https://rackhd.atlassian.net/browse/RAC-2020