Refactor progress code #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
* This PR is to address Felix's comments on ipxe progress API,_getActiveTask function and progress data type. * Code is udpated based on comments. * No feature impacted.
brianparry
reviewed
Jan 10, 2017
| .then(function (activeTask) { | ||
| return activeTask.taskId; | ||
| }); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Just a minor suggestion, but I think this would be a little easier to read if written like:
return Promise.try(function() {
if (nodeId) {
return taskProtocol.activeTaskExists(nodeId)
.then(function (activeTask) {
return activeTask.taskId;
});
}
});
brianparry
approved these changes
Jan 10, 2017
Contributor
brianparry
left a comment
brianparry
left a comment
There was a problem hiding this comment.
Minor style comment, but otherwise 👍
yyscamper
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API,_getActiveTask function and progress data type.