-
Couldn't load subscription status.
- Fork 699
v6: Rewrite release #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6: Rewrite release #853
Conversation
- `node_modules/.bin/webpack` to build dist - `yarn start` to run on localhost
Rewrite: add webpack mdx
* add styled-components dependency * move component files out of respective folders, update imports * Change Deck.js so that it provides a render prop to the child. * Modify Controls.js so that they accept dispatch prop and render buttons. * Modify test.mdx so that it renders Controls and a currentSlide value. * Refactored to use hooks * Added 'SlideElement' logic to Slide. * Finished slide logic * removed Controls as no longer needed. * Add SlideElementWrapper for animated elements * Add note about loop prop for Deck * Add example using JS rather than just MDX (#694) * moved slideElementWrapper into own component * Implement react spring transitions * added custom transitionEffect prop to Slide component. * Fixed MDX and JS examples * SlideElementWrapper can accept custom springs now! * Added proptypes * Fixed some animation issues with precision. * Added configuration so when going backwards you could skip animations. * Implemented debounced keypress, so can skip animations if skipping through slides. * Fixed some issues with transitionEffects * Add immediate to note s that it is a React-Spring property. * Fix cleanup function for useSlide.
use kebab-case consistently throughout project
MDX Slide Parsing and CLI
* Host presentation demos elsewhere * Update bg-demos for docs lander * document export mode * update scripts * remove duplicated screen recordings * docs & TOC cleanup
- Export `indentNormalizer` for manual use. - Add `indentNormalizer` unit tests. - Update examples/js and examples/one-page. Fixes #846 - Looks like `yarn build-one-page` also needed running to catch up.
* Remove lineHeight unit from notes text * Expand slide background support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!!! I have a couple of minor things, and otherwise everything that I've skimmed (most stuff outside the core library code and docs content) is in good shape.
🎉
* add new spectacle logo * improve svg styles * Refresh demos
* Style updates for Docs * Prevent borders when code tags are inside gatsby blocks
- Bandaid prism postcss minification bug by disabling CSS minification. For #857 as a temporary measure. - Add missing `docs/dist-prod/open-source/spectacle` symlink needed for `yarn prod:serve` - Catch `yarn.lock` up. This should fail yarn install in CI, so not sure if this is something just on my machine as I didn't change deps... - Lint was super slow, so I updated lints so docs one is more honed (had duplicates) and root project one now only lints specific dirs (it was doing way too many after docs addition of things that were not real source) and does the root + docs so you only really need the root one.
This PR releases the rewritten Spectacle library, otherwise known as v6.
There are a number of important changes to note that will be documented in release notes & an upcoming blog post, but the most important takeaway is the API has changed completely.
stage deploy of docs site
Closes #716
Remaining To-Do's: