Add example using JS rather than just MDX #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kale-stew
pushed a commit
that referenced
this pull request
Jul 31, 2019
* add styled-components dependency * move component files out of respective folders, update imports * Change Deck.js so that it provides a render prop to the child. * Modify Controls.js so that they accept dispatch prop and render buttons. * Modify test.mdx so that it renders Controls and a currentSlide value. * Refactored to use hooks * Added 'SlideElement' logic to Slide. * Finished slide logic * removed Controls as no longer needed. * Add SlideElementWrapper for animated elements * Add note about loop prop for Deck * Add example using JS rather than just MDX (#694) * moved slideElementWrapper into own component * Implement react spring transitions * added custom transitionEffect prop to Slide component. * Fixed MDX and JS examples * SlideElementWrapper can accept custom springs now! * Added proptypes * Fixed some animation issues with precision. * Added configuration so when going backwards you could skip animations. * Implemented debounced keypress, so can skip animations if skipping through slides. * Fixed some issues with transitionEffects * Add immediate to note s that it is a React-Spring property. * Fix cleanup function for useSlide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestJSexampleindex.jswhere we're testing rendering these files. KeptMDXDocumentin so we can switch easily for nowDeckmap