Skip to content

Conversation

@treyhoover
Copy link
Contributor

Description

Fixes an issue with notes overlapping in presenter view. (See image below for bug)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

image

@treyhoover
Copy link
Contributor Author

The issue is highlighted here: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values

@ryan-roemer, This is only an issue when using spectacle-mdx-loader because the generated html is slightly different (each note has an extra div). This change should resolve that, but we may want to create a separate issue for that project to standardize the html outputted.

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with one-page.html in this repository and yarn link-ed it to the private project that used spectacle-cli + MDX and the changes all look good everywhere! 🎉

@ryan-roemer
Copy link
Member

@treyhoover -- Let's maybe also file the spectacle-mdx-loader issue with a lower priority just to track it as it would be nice to harmonize the outputs across JSX/MD/MDX modes.

@treyhoover
Copy link
Contributor Author

@treyhoover -- Let's maybe also file the spectacle-mdx-loader issue with a lower priority just to track it as it would be nice to harmonize the outputs across JSX/MD/MDX modes.

Sure thing. Captured here.

@kale-stew kale-stew merged commit e8b1a0e into task/rewrite Mar 4, 2020
@kale-stew kale-stew deleted the bug/presenter-lines branch March 4, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants