Docs: Add screen recordings, fix broken links #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important to note: this is not the final docs PR, that will be #844 where we point all the docs to |
carloskelly13
approved these changes
Feb 20, 2020
|
Blocked until I can test out these changes on a staged deployment, waiting for Surge credentials |
ryan-roemer
reviewed
Feb 21, 2020
ryan-roemer
reviewed
Feb 21, 2020
ryan-roemer
reviewed
Feb 23, 2020
| "prod:build": "react-static build", | ||
| "prod:serve": "serve -l 3000", | ||
| "prod:deploy": "node scripts/deploy/aws.js", | ||
| "prettier-all": "npx prettier --write '{src,static-config-helpers,static-config-parts,static.config,scripts,lib}/**/*.{js,jsx}'", |
There was a problem hiding this comment.
For a future ticket, let's get rid of all npx. It's much better and faster to use our actual deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes care of the rest of the broken links in our documentation (that I know of 🤔) and fixes the demo presentation we loop over in our lander.
Deployment preview