Skip to content

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented Mar 5, 2020

Description

Fixes anchor links
Updates styles to be inline with other docs landers

Screen Shot 2020-03-05 at 4 32 39 PM

Screen Shot 2020-03-05 at 4 32 52 PM

Fixes #812
Screen Shot 2020-03-05 at 4 47 04 PM

@carloskelly13 carloskelly13 requested a review from kale-stew March 5, 2020 23:31
@kale-stew
Copy link
Contributor

Oh noo it looks like that weird rogue indentation for some codeblocks is re appearing, could be a regression introduced (we got rid of it when we first brought docs into this repo). LGTM, we can polish within the v6 rewrite branch as needed 👍

} from '../../components/navigation';
import closeButton from '../../static/svgs/x.svg';
import logoSidebar from '../../static/svgs/logo-sidebar.svg';
import logoSidebar from '../../static/bg_hero_badge.png';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we delete the logo-sidebar svg if it's not being used elsewhere?

Copy link
Contributor

@kale-stew kale-stew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to remove the logo-sidebar svg in task/rewrite itself, otherwise this LGTM! 🚢

@kale-stew kale-stew merged commit 3bfc740 into task/rewrite Mar 6, 2020
@kale-stew kale-stew deleted the task/rewrite-docs-style-updates branch March 6, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants