use kebab-case consistently throughout project #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunburtReynolds
requested review from
VirtualDOMinic,
kiraarghy,
narinluangrath and
rgerstenberger
|
LGTM |
| import slides from './slides.mdx'; | ||
| import Deck from '../../src/components/Deck'; | ||
| import Slide from '../../src/components/Slide'; | ||
| import Deck from '../../src/components/deck'; |
There was a problem hiding this comment.
This is still /MDX/* which doesn't solve the problem.
There was a problem hiding this comment.
It's lower case locally. I tried to make it upper then lower case again. No diff in git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per @rgerstenberger's comment on another PR, we want to use
kebab-caseconsistently to avoid cross-platform file system issues.Type of Change
How Has This Been Tested?
I retested CLI functionality, and everything is normal.