Skip to content

Conversation

@treyhoover
Copy link
Contributor

Description

Expands custom background support by adding Background props to the Slide component, along with backgroundOpacity.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Added an example slide

Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only thing to add is to the UNRELEASED section in the change-log what you've added

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested one-page and looks great!

@treyhoover treyhoover force-pushed the feature/background-image branch from e6da320 to bbafa7c Compare February 28, 2020 18:57
@treyhoover
Copy link
Contributor Author

This looks great. Only thing to add is to the UNRELEASED section in the change-log what you've added

@carlos-kelly How's that? Feel free to merge if it's ready - I'm about to board my flight.

@carloskelly13 carloskelly13 merged commit fd532ee into task/rewrite Mar 2, 2020
@carloskelly13 carloskelly13 deleted the feature/background-image branch March 2, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants