release: 2.6.0 #3455

faustbrian · 2020-02-10T04:35:56Z

No description provided.

Co-authored-by: Renovate Bot <bot@renovateapp.com>

) If the block validation fails and there are any exceptions, instead of continuing right away, rerun the schema validation without bailing out on the first encountered error. This ensures all bignumber properties are properly converted.

…point (#3005)

Emit `round.missed` whenever an active delegate didn't forge any blocks during a round.

Prevents memory spikes during bootstrap phase by loading transactions of the same type in batches instead of all at once into memory during bootstrap.

The ajv address schema calls `Base58.decodeCheck` to validate the network byte. But during transaction serialization, the address is also decoded, so we end up doing it again. By performing the network byte validation during transaction serialization we can get rid of the decode call during schema validation. This makes multipayment processing approx. 25% faster.

findByAddress() is returning a reference to the stored wallet object, so modifying its balance property also modifies what is stored in the wallet manager, no need to re-insert it. This boosts the apply phase of the multi-payment bootstrap from ~9sec to ~6sec.

On mainnet database (9912558 blocks, 3171992 transactions): SELECT * FROM transactions WHERE type = 6; no index: 700ms, with index: 1ms SELECT * FROM transactions WHERE type = 1; no index: 650ms, with index: 14ms SELECT * FROM transactions WHERE type = 3; no index: 1280ms, with index: 480ms SELECT * FROM transactions WHERE type = 0; no index: 11500ms, with index: 11500ms (the index is not used) bootstrap no index: 22sec, with index: 20sec

#3037)

Disable the TransactionReader because it inflicts a minor performance regression. However, do not completely delete it from the source code because we may revisit it later when the database queries start returning way too many rows to the nodejs app at once. The proper solution is to execute the database query once and serve the results to the app on portions using cursors, rather than executing the same query multiple times and chopping the portions using OFFSET,LIMIT.

#3049)

* We support utf8 strings for vendor field * \u0000 (nul byte) is a valid utf8 string * PostgreSQL cannot store \u0000 in VARCHAR It follows that we cannot use VARCHAR for storing vendor field. So use bytea for that.

…nts (#3430)

…l api attributes (#3437)

…locks (#3440)

codecov · 2020-02-10T04:45:50Z

Codecov Report

❗ No coverage uploaded for pull request base (master@9ac0c72). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3455   +/-   ##
=========================================
  Coverage          ?   66.16%           
=========================================
  Files             ?      439           
  Lines             ?    12458           
  Branches          ?     1708           
=========================================
  Hits              ?     8243           
  Misses            ?     4181           
  Partials          ?       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac0c72...13d7f83. Read the comment docs.

lgtm-com · 2020-02-10T05:00:55Z

This pull request introduces 1 alert and fixes 14 when merging cdfde55 into 9ac0c72 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

fixed alerts:

9 for Unused variable, import, function or class
3 for Unneeded defensive code
2 for Useless assignment to local variable

lgtm-com · 2020-02-10T05:45:56Z

This pull request introduces 1 alert and fixes 14 when merging 3a6b655 into 9ac0c72 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

fixed alerts:

9 for Unused variable, import, function or class
3 for Unneeded defensive code
2 for Useless assignment to local variable

lgtm-com · 2020-02-11T07:44:57Z

This pull request introduces 1 alert and fixes 14 when merging 64fe08c into 9ac0c72 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

fixed alerts:

9 for Unused variable, import, function or class
3 for Unneeded defensive code
2 for Useless assignment to local variable

lgtm-com · 2020-02-11T08:32:21Z

This pull request introduces 1 alert and fixes 14 when merging dabd270 into 9ac0c72 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

fixed alerts:

9 for Unused variable, import, function or class
3 for Unneeded defensive code
2 for Useless assignment to local variable

…3458)

lgtm-com · 2020-02-11T08:59:12Z

This pull request introduces 1 alert and fixes 14 when merging 13d7f83 into 9ac0c72 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

fixed alerts:

9 for Unused variable, import, function or class
3 for Unneeded defensive code
2 for Useless assignment to local variable

spkjp and others added 30 commits October 1, 2019 09:49

feat(crypto): allow passing height to configManager.isNewMilestone (#…

409cedb

…3001)

fix(deps): update dependency @hapi/boom to v8 (#2988)

14dfc07

Co-authored-by: Renovate Bot <bot@renovateapp.com>

refactor(core-api): add vendorField and timestamp to /locks end…

ee6fe40

…point (#3005)

refactor(core-api): integrate hapi-pagination to replace fork (#2994)

279585b

refactor: add round.missed event (#3011)

4953e48

Emit `round.missed` whenever an active delegate didn't forge any blocks during a round.

perf(crypto): replace bignumber.js with native BigInt (#3010)

7469ee9

refactor(core-transactions): bootstrap transactions in batches (#2997)

27132f0

Prevents memory spikes during bootstrap phase by loading transactions of the same type in batches instead of all at once into memory during bootstrap.

perf(crypto): memoize base58 de/encoding (#3015)

b65a0e0

ci: run push events on master and develop, rest on PRs

6de1767

refactor: remove vendorFieldHex (#3014)

575234e

perf(core-transactions): htlc bootstrap (#3023)

ea1dea0

feat(core-snapshots): add support for transaction nonces (#2925)

daa830f

refactor(core-http-utils): add trailing-slash plugin (#3027)

2a81383

chore(new-relic): update dependencies to support node.js 12 (#3028)

334d59a

fix(crypto): match the long version of bytebuffer (#3025)

516a586

fix(core-forger): use correct IV length for encryption (#3036)

2aad9ef

fix(crypto): add legacy multisignature schema (#3040)

19ad6b4

fix: basic validation on incoming p2p data + terminate socket on error (

92e0115

#3037)

fix(core-transactions): delegate resignation (#3045)

9107c84

fix(core-api): missing confirmations for lock transactions (#3046)

7b0fe0e

chore(core-database-postgres): load migration file names automatically (

9a6de2d

#3049)

fix(core-p2p): convert isAppReady response to object (#3050)

892a610

fix(core-database-postgres): store vendor field in bytea (#3048)

63dc252

* We support utf8 strings for vendor field * \u0000 (nul byte) is a valid utf8 string * PostgreSQL cannot store \u0000 in VARCHAR It follows that we cannot use VARCHAR for storing vendor field. So use bytea for that.

chore: switch to TypeScript 3.6 (#3057)

38156bc

refactor(core-p2p): cleanup socket errors (#3056)

2226abe

air1one and others added 8 commits January 29, 2020 12:46

perf(core-database-postgres): use type index when querying multipayme…

1e4c2d1

…nts (#3430)

docs: 2.6.0 changelog (#3435)

782e073

fix(core-tester-cli): set network height on configManager (#3432)

481d59f

refactor(core-api): re-enable username and 2nd public key as top-leve…

d26701e

…l api attributes (#3437)

refactor(core-p2p): timeouts for peer socket messages (#3439)

f20abf4

fix(core-transactions): apply genesis wallet exception to lastForgedB…

6dbae81

…locks (#3440)

release: 2.6.0-next.10 (#3441)

fa87247

release: 2.6.0 (#3454)

0b3794f

ghost added Complexity: Undetermined labels Feb 10, 2020

faustbrian marked this pull request as ready for review February 10, 2020 04:36

faustbrian requested review from air1one and kristjank as code owners February 10, 2020 04:36

ghost added Status: Needs Review and removed Status: In Progress labels Feb 10, 2020

Merge branch 'master' into develop

cdfde55

chore(core-p2p): merge patch from master (#3456)

3a6b655

chore: update aip11 milestone + update p2p minver defaults (#3460)

64fe08c

test(core-p2p): fix minver unit test (#3462)

dabd270

chore(exchange-json-rpc): use @arkecosystem/exchange-json-rpc@2.0.0 (#…

13d7f83

…3458)

faustbrian merged commit 13d7f83 into master Feb 11, 2020

ghost removed the Status: Needs Review label Feb 11, 2020

ghost mentioned this pull request Feb 16, 2020

[Weekly Digest] Feb 10, 2020 - Feb 16, 2020 #3509

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: 2.6.0 #3455

release: 2.6.0 #3455

faustbrian commented Feb 10, 2020

codecov bot commented Feb 10, 2020 •

edited

Loading

lgtm-com bot commented Feb 10, 2020

lgtm-com bot commented Feb 10, 2020

lgtm-com bot commented Feb 11, 2020

lgtm-com bot commented Feb 11, 2020

lgtm-com bot commented Feb 11, 2020

release: 2.6.0 #3455

release: 2.6.0 #3455

Conversation

faustbrian commented Feb 10, 2020

codecov bot commented Feb 10, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Feb 10, 2020

lgtm-com bot commented Feb 10, 2020

lgtm-com bot commented Feb 11, 2020

lgtm-com bot commented Feb 11, 2020

lgtm-com bot commented Feb 11, 2020

codecov bot commented Feb 10, 2020 •

edited

Loading