Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-tester-cli): set network height on configManager #3432

Merged
merged 3 commits into from
Feb 4, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jan 30, 2020

Summary

For core-tester-cli, set the network height on configManager in order to have it correctly configured (milestones depend on height).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #3432 into develop will increase coverage by 16.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3432       +/-   ##
============================================
+ Coverage    49.42%   66.16%   +16.73%     
============================================
  Files          439      439               
  Lines        12444    12446        +2     
  Branches      1702     1702               
============================================
+ Hits          6151     8235     +2084     
+ Misses        6272     4178     -2094     
- Partials        21       33       +12     
Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 73.46% <0.00%> (+0.76%) ⬆️
packages/core-state/src/wallets/wallet-manager.ts 90.72% <0.00%> (+1.61%) ⬆️
packages/core-transaction-pool/src/memory.ts 98.66% <0.00%> (+2.00%) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 93.18% <0.00%> (+4.54%) ⬆️
packages/core-transaction-pool/src/connection.ts 91.86% <0.00%> (+6.09%) ⬆️
packages/core-p2p/src/peer-connector.ts 67.44% <0.00%> (+6.97%) ⬆️
packages/core-p2p/src/utils/is-valid-version.ts 100.00% <0.00%> (+7.14%) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 65.51% <0.00%> (+8.62%) ⬆️
...ain/src/processor/handlers/accept-block-handler.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/core-p2p/src/peer-processor.ts 81.25% <0.00%> (+10.41%) ⬆️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782e073...f4aac0d. Read the comment docs.

@faustbrian faustbrian merged commit 481d59f into develop Feb 4, 2020
@ghost ghost deleted the fix/core-tester-cli/config-network-height branch February 4, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants