-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-api): integrate hapi-pagination to replace fork #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
requested review from
air1one,
kristjank and
spkjp
as code owners
September 29, 2019 07:42
ghost
added
Complexity: High
labels
Sep 29, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2994 +/- ##
===========================================
- Coverage 66.08% 66.07% -0.01%
===========================================
Files 420 423 +3
Lines 10046 10100 +54
Branches 514 532 +18
===========================================
+ Hits 6639 6674 +35
- Misses 3364 3382 +18
- Partials 43 44 +1
Continue to review full report at Codecov.
|
faustbrian
force-pushed
the
refactor/hapi-pagination
branch
3 times, most recently
from
September 29, 2019 13:45
59815da
to
4f57459
Compare
faustbrian
force-pushed
the
refactor/hapi-pagination
branch
from
September 29, 2019 14:21
4f57459
to
448a3bf
Compare
ghost
mentioned this pull request
Sep 29, 2019
dated
reviewed
Sep 30, 2019
Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>
Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>
spkjp
approved these changes
Oct 2, 2019
ghost
deleted the
refactor/hapi-pagination
branch
October 2, 2019 22:48
Closed
ghost
mentioned this pull request
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate the https://github.com/faustbrian/hapi-pagination repository directly into
core-api
and update all hapi dependencies to the@hapi/*
namespace.This gets rid of a bunch of dependencies and the need to keep a fork alive, also gives us the freedom to make any change we need to do. Also removes the warning about the outdated
hapi
scope when you install core.Checklist