Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core-database-postgres): use type index when querying multipayments #3430

Merged

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jan 28, 2020

Summary

Query by type to use type index when querying multipayments to improve performance.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

use type index when querying multipayments for performance
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #3430 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3430   +/-   ##
========================================
  Coverage    66.16%   66.16%           
========================================
  Files          439      439           
  Lines        12444    12444           
  Branches      1702     1702           
========================================
  Hits          8233     8233           
  Misses        4178     4178           
  Partials        33       33
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 17.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117bb9e...cbb6191. Read the comment docs.

@faustbrian faustbrian changed the title refactor(core-database-postgres): improve wallet transactions query (performance) perf(core-database-postgres): improve wallet transactions query Jan 29, 2020
@faustbrian faustbrian changed the title perf(core-database-postgres): improve wallet transactions query perf(core-database-postgres): use type index when querying multipayments Jan 29, 2020
@faustbrian faustbrian merged commit 1e4c2d1 into develop Jan 29, 2020
@faustbrian faustbrian deleted the refactor/core-database-postgres/transactions-query-wallet branch January 29, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants