fix(core-database-postgres): store vendor field in bytea #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
Codecov Report
@@ Coverage Diff @@
## develop #3048 +/- ##
===========================================
+ Coverage 65.61% 65.62% +<.01%
===========================================
Files 425 425
Lines 11733 11733
Branches 1595 1595
===========================================
+ Hits 7699 7700 +1
Misses 3997 3997
+ Partials 37 36 -1
Continue to review full report at Codecov.
|
* We support utf8 strings for vendor field * \u0000 (nul byte) is a valid utf8 string * PostgreSQL cannot store \u0000 in VARCHAR It follows that we cannot use VARCHAR for storing vendor field. So use bytea for that.
vasild
force-pushed
the
fix-vendor-field-decode
branch
from
ea98df1
to
5a70810
Compare
vasild
changed the title
spkjp
approved these changes
Oct 10, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows that we cannot use VARCHAR for storing vendor field.
So use bytea for that.