Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove vendorFieldHex #3014

Merged
merged 7 commits into from
Oct 3, 2019
Merged

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 3, 2019

Summary

Removes vendorFieldHex and migrates the transactions table from vendor_field_hex to vendor_field.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@6de1767). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3014   +/-   ##
==========================================
  Coverage           ?   65.54%           
==========================================
  Files              ?      423           
  Lines              ?    10221           
  Branches           ?      547           
==========================================
  Hits               ?     6699           
  Misses             ?     3477           
  Partials           ?       45
Impacted Files Coverage Δ
packages/crypto/src/transactions/deserializer.ts 91.11% <ø> (ø)
packages/crypto/src/transactions/serializer.ts 87.82% <ø> (ø)
packages/crypto/src/transactions/types/schemas.ts 100% <ø> (ø)
...kages/core-api/src/handlers/transactions/schema.ts 100% <ø> (ø)
...kages/crypto/src/transactions/types/transaction.ts 75% <ø> (ø)
packages/core-api/src/handlers/wallets/schema.ts 100% <ø> (ø)
...s/core-database-postgres/src/models/transaction.ts 100% <ø> (ø)
packages/core-api/src/handlers/votes/schema.ts 100% <ø> (ø)
packages/core-api/src/handlers/blocks/schema.ts 100% <ø> (ø)
...ckages/core-transactions/src/handlers/htlc-lock.ts 73.33% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de1767...30fb722. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 3, 2019

This pull request introduces 1 alert when merging 82dcf59 into b65a0e0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@faustbrian faustbrian merged commit 575234e into develop Oct 3, 2019
@ghost ghost deleted the refactor/remove-vendor-field-hex branch October 3, 2019 12:48
vasild added a commit that referenced this pull request Oct 4, 2019
…ts-nonce

* ArkEcosystem/core/develop:
  refactor: remove `vendorFieldHex` (#3014)
  ci: run push events on master and develop, rest on PRs
  perf(crypto): memoize base58 de/encoding (#3015)
  refactor(core-transactions): bootstrap transactions in batches (#2997)
  perf(crypto): replace bignumber.js with native BigInt (#3010)
  refactor: add `round.missed` event (#3011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants