Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core-transactions): htlc bootstrap #3023

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 5, 2019

Summary

Optimizes the HTLC bootstrap by excluding claimed/refunded locks and ensuring that each wallet is only indexed once.

Before:

[2019-10-05 01:13:50.419] INFO : State Generation - Step 10 of 20: DelegateResignation
[2019-10-05 01:13:50.458] INFO : State Generation - Step 11 of 20: HtlcLock
[2019-10-05 01:14:30.826] INFO : State Generation - Step 12 of 20: HtlcClaim
[2019-10-05 01:14:41.115] INFO : State Generation - Step 13 of 20: HtlcRefund
[2019-10-05 01:14:41.217] INFO : State Generation - Step 14 of 20: BusinessRegistration

After:

[2019-10-05 01:15:06.293] INFO : State Generation - Step 10 of 20: DelegateResignation
[2019-10-05 01:15:06.326] INFO : State Generation - Step 11 of 20: HtlcLock
[2019-10-05 01:15:06.611] INFO : State Generation - Step 12 of 20: HtlcClaim
[2019-10-05 01:15:06.670] INFO : State Generation - Step 13 of 20: HtlcRefund
[2019-10-05 01:15:06.685] INFO : State Generation - Step 14 of 20: BusinessRegistration

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #3023 into develop will increase coverage by 0.05%.
The diff coverage is 18.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3023      +/-   ##
===========================================
+ Coverage    65.83%   65.88%   +0.05%     
===========================================
  Files          424      424              
  Lines        10167    10162       -5     
  Branches       538      538              
===========================================
+ Hits          6693     6695       +2     
+ Misses        3428     3422       -6     
+ Partials        46       45       -1
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 22.8% <0%> (-1.27%) ⬇️
...ckages/core-transactions/src/transaction-reader.ts 8.33% <0%> (ø) ⬆️
...ckages/core-transactions/src/handlers/htlc-lock.ts 70.21% <0%> (-2.13%) ⬇️
...c/repositories/transactions-business-repository.ts 83.07% <0%> (-4.02%) ⬇️
...ages/core-transactions/src/handlers/htlc-refund.ts 85.33% <37.5%> (+6.58%) ⬆️
...kages/core-transactions/src/handlers/htlc-claim.ts 86.74% <44.44%> (+6.97%) ⬆️
packages/core-api/src/plugins/pagination/ext.ts 81.81% <0%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdb728...c513903. Read the comment docs.

@faustbrian faustbrian merged commit ea1dea0 into develop Oct 5, 2019
@ghost ghost deleted the perf/htlc-bootstrap branch October 5, 2019 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants