Skip to content

Conversation

@lazysegtree
Copy link
Collaborator

@lazysegtree lazysegtree commented May 15, 2025

Issues

Prompt Tutorial

image image

Show footer info flag

flag as true
image

flag as false
image

Minimalistic look

image

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated automated workflow to run on both the main and develop branches for improved build and test coverage.
  • New Features
    • Added detailed documentation for SPF Prompt modes, including Shell and SPF modes with usage examples and hotkeys.
    • Introduced a configuration option to hide additional footer information in the file panel.
  • Bug Fixes
    • Improved prompt UI text formatting and labels for clarity.
    • Refined error messages related to SPF commands for better user understanding.
  • Documentation
    • Enhanced hotkey list with distinct entries for opening Shell mode and SPF mode prompts.
    • Added documentation for new configuration option controlling footer info display in the file panel.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 15, 2025

Walkthrough

The GitHub Actions workflow was updated to trigger on both main and develop branches for push and pull request events. The prompt UI text and formatting were refined, including mode labels and error messages. A new configuration option was added to control footer info display in file panels. Documentation was extended with details on two prompt modes and corresponding hotkeys.

Changes

File(s) Change Summary
.github/workflows/superfile-build-test.yml Updated workflow triggers to include both main and develop branches for push and pull request events. No changes to workflow steps.
src/internal/ui/prompt/consts.go Changed constant spfModeString from "(Prompt Mode)" to "(SPF Mode)".
src/internal/ui/prompt/model.go Added space before mode string in prompt border title; simplified SPF prompt hotkey description text.
src/internal/ui/prompt/model_test.go Updated expected prompt rendering strings to reflect spacing and text changes; adjusted box border widths.
src/internal/ui/prompt/utils.go Modified error message text by removing "prompt" from "Invalid spf prompt command" to "Invalid spf command".
src/internal/ui/prompt/utils_test.go Updated test to expect modified error message string without "prompt".
src/internal/common/config_type.go Added boolean config field ShowPanelFooterInfo to control footer info display in file panel.
src/internal/model_render.go Modified file panel render logic to conditionally hide footer info based on ShowPanelFooterInfo config.
src/superfile_config/config.toml Added show_panel_footer_info boolean option with default true.
website/src/content/docs/getting-started/tutorial.md Added new "SPF Prompt" section describing two prompt modes (Shell and SPF), usage, keybindings, and examples.
website/src/content/docs/list/hotkey-list.md Split command execution bar hotkey entry into two: shell mode (:) and SPF mode (>), with updated descriptions.
website/src/content/docs/configure/superfile-config.mdx Documented new show_panel_footer_info boolean configuration option controlling footer info display; fixed grammar in show_image_preview description.

Poem

Two modes to hop and play,
Shell and SPF light the way.
Keys : and > guide the run,
Commands and prompts, all in fun.
Footer info hides or shows,
Bunny cheers as progress grows! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e0e8cec and 4f11804.

📒 Files selected for processing (4)
  • src/internal/common/config_type.go (1 hunks)
  • src/internal/model_render.go (1 hunks)
  • src/superfile_config/config.toml (1 hunks)
  • website/src/content/docs/configure/superfile-config.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • src/internal/common/config_type.go
  • website/src/content/docs/configure/superfile-config.mdx
  • src/superfile_config/config.toml
  • src/internal/model_render.go
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lazysegtree lazysegtree changed the title fix(cicd): Add develop branch in github workflow Write prompt tutorial, rename prompt mode to spf mode , add develop branch in github workflow May 16, 2025
@lazysegtree lazysegtree added the documentation Improvements or additions to documentation label May 16, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
website/src/content/docs/getting-started/tutorial.md (1)

181-207: Great addition of SPF Prompt documentation!

The new section clearly explains the two prompt modes (Shell Mode and SPF Mode), their access methods (: and > respectively), available commands, and usage examples. The screenshots are helpful for user understanding.

Minor grammatical correction needed on line 207:

-Press `esc` or `ctrl`+`c` to exit Prompt.
+Press `esc` or `ctrl`+`c` to exit the Prompt.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~207-~207: You might be missing the article “the” here.
Context: ...h)) Pressescorctrl+c` to exit Prompt.

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 283a1f5 and f291156.

⛔ Files ignored due to path filters (2)
  • asset/prompt_shell_mode.png is excluded by !**/*.png
  • asset/prompt_spf_mode.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • src/internal/ui/prompt/consts.go (1 hunks)
  • src/internal/ui/prompt/model.go (2 hunks)
  • src/internal/ui/prompt/model_test.go (2 hunks)
  • src/internal/ui/prompt/utils.go (1 hunks)
  • src/internal/ui/prompt/utils_test.go (1 hunks)
  • website/src/content/docs/getting-started/tutorial.md (1 hunks)
  • website/src/content/docs/list/hotkey-list.md (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • src/internal/ui/prompt/consts.go
  • src/internal/ui/prompt/utils.go
  • website/src/content/docs/list/hotkey-list.md
  • src/internal/ui/prompt/model.go
  • src/internal/ui/prompt/model_test.go
🧰 Additional context used
🪛 LanguageTool
website/src/content/docs/getting-started/tutorial.md

[uncategorized] ~207-~207: You might be missing the article “the” here.
Context: ...h)) Pressescorctrl+c` to exit Prompt.

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

🔇 Additional comments (1)
src/internal/ui/prompt/utils_test.go (1)

71-71: Correctly updated error message to match implementation changes

The error message has been updated from "Invalid prompt command : abcd" to "Invalid spf command : abcd", which aligns with the broader change of renaming "prompt mode" to "spf mode" throughout the application. This maintains consistency between the test expectations and actual error messages.

@lazysegtree lazysegtree changed the title Write prompt tutorial, rename prompt mode to spf mode , add develop branch in github workflow Write prompt tutorial, rename prompt mode to spf mode , add develop branch in github workflow, hide_panel_footer_info flag May 16, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/internal/model_render.go (1)

125-133: Implementation looks good, but consider aligning variable naming with behavior.

The conditional rendering of footer items based on the HidePanelFooterInfo flag is well-implemented. The logic for handling truncated items by using smaller versions is also a nice touch.

However, the naming of the configuration flag seems counterintuitive since when HidePanelFooterInfo is true, it actually shows additional footer info, not hides it. Consider renaming this flag to ShowPanelFooterInfo to make the behavior more intuitive and consistent with other similar flags like show_image_preview.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between f291156 and c2e96b3.

📒 Files selected for processing (4)
  • src/internal/common/config_type.go (1 hunks)
  • src/internal/model_render.go (1 hunks)
  • src/superfile_config/config.toml (1 hunks)
  • website/src/content/docs/configure/superfile-config.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • src/superfile_config/config.toml
  • src/internal/common/config_type.go
🧰 Additional context used
🪛 LanguageTool
website/src/content/docs/configure/superfile-config.mdx

[grammar] ~108-~108: After the auxiliary verb ‘do’, use the base form of a verb. Did you mean “show”?
Context: ...ode and sort type. false => Does not shows additional footer info for file panel ...

(AUXILIARY_DO_WITH_INCORRECT_VERB_FORM)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (go)

@lazysegtree lazysegtree changed the title Write prompt tutorial, rename prompt mode to spf mode , add develop branch in github workflow, hide_panel_footer_info flag Write prompt tutorial, rename prompt mode to spf mode , add develop branch in github workflow, show_panel_footer_info flag May 16, 2025
@lazysegtree
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 16, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@lazysegtree lazysegtree added new feature high priority Issue/PR/Feature/bug that is considered high priority. labels May 16, 2025
@lazysegtree lazysegtree merged commit 1a940d7 into main May 17, 2025
9 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 23, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [yorukot/superfile](https://github.com/yorukot/superfile) | minor | `v1.2.1` -> `v1.3.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>yorukot/superfile (yorukot/superfile)</summary>

### [`v1.3.0`](https://github.com/yorukot/superfile/releases/tag/v1.3.0)

[Compare Source](yorukot/superfile@v1.2.1...v1.3.0)

We are excited to release v1.3.0 for superfile, with new features, key bug fixes, and lots of polish under the hood.

#### Install:

[**Click me to know how to install**](https://github.com/yorukot/superfile?tab=readme-ov-file#installation)

#### Highlights

-   We have revamped the command prompt and added built-in commands for SuperFile-specific actions. Check out yorukot/superfile#745

-   Multi-panel startup support. You can now open multiple panels right from startup, making your workflow even more efficient.

-   Added new configurations :  --chooser-file option, show_panel_footer_info config flag and many command prompt specific flags.

#### Improvements & Fixes

-   The sidebar code was refactored and separated for better maintainability and various linter fixes and CI/CD improvements were made to keep the codebase clean and robust.

-   A new Rendering package is implemented, centralising border, content, and section rendering logic into reusable renderer components, fixing many layout bugs.

-   Model behaviour, file operations and rendering-related unit tests were added to improve test coverage.

#### Detailed Change Summary

<details><summary>Details</summary>
<p>

#### New Features

-   Added a Command-Prompt for SuperFile specific actions [`#752`](yorukot/superfile#752) by [@&#8203;Rocco-Gossmann](https://github.com/Rocco-Gossmann), [@&#8203;yorukot](https://github.com/yorukot)  and [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Allow specifying multiple panels at startup [`#759`](yorukot/superfile#759) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Initial draft of rendering package [`#775`](yorukot/superfile#775) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Render unit tests for prompt model [`#809`](yorukot/superfile#809) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Chooser file option, --lastdir-file option, and improvements in quit, and bug fixes [`#812`](yorukot/superfile#812) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Prompt feature leftover items [`#804`](yorukot/superfile#804) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   SPF Prompt tutorial and fixes [`#814`](yorukot/superfile#814) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Write prompt tutorial, rename prompt mode to spf mode, add develop branch in GitHub workflow, show_panel_footer_info flag [`#815`](yorukot/superfile#815) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Theme: Add gruvbox-dark-hard [`#828`](yorukot/superfile#828) by [@&#8203;Frost-Phoenix](https://github.com/Frost-Phoenix)

#### Updates & Improvements

-   Sidebar separation [`#767`](yorukot/superfile#767) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Sidebar code separation [`#770`](yorukot/superfile#770) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Rendering package and rendering bug fixes [`#781`](yorukot/superfile#781) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Refactor CheckForUpdates [`#797`](yorukot/superfile#797) by [@&#8203;JassonCordones](https://github.com/JassonCordones)
-   Rename metadata strings [`#731`](yorukot/superfile#731) by [@&#8203;booth-w](https://github.com/booth-w)

#### Bug Fixes

-   Fix crash with opening file with editor on an empty panel [`#730`](yorukot/superfile#730) by [@&#8203;booth-w](https://github.com/booth-w)
-   Fix: Add some of the remaining linter and fix errors [`#756`](yorukot/superfile#756) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Golangci lint fixes [`#757`](yorukot/superfile#757) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Fix: Remove redundant function containsKey [`#765`](yorukot/superfile#765) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Fix: Correctly resolve path in open and cd prompt actions [`#802`](yorukot/superfile#802) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Prompt dynamic dimensions and unit tests fix [`#805`](yorukot/superfile#805) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Fix: Convert unicode space to normal space, use rendered in file preview to fix layout bugs, Release 1.3.0 [`#825`](yorukot/superfile#825) by [@&#8203;lazysegtree](https://github.com/lazysegtree)

#### Optimization & Code Quality

-   Adding linter to CI/CD and fix some lint issues [`#739`](yorukot/superfile#739) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Linter fixes, new feature of allowing multiple directories at startup, other code improvements [`#764`](yorukot/superfile#764) by [@&#8203;lazysegtree](https://github.com/lazysegtree)
-   Model unit tests [`#803`](yorukot/superfile#803) by [@&#8203;lazysegtree](https://github.com/lazysegtree)

#### Dependency Updates

-   fix(deps): update dependency astro to v5.7.7 [`#726`](yorukot/superfile#726) by [@&#8203;renovate](https://github.com/renovate)
-   fix(deps): update module github.com/shirou/gopsutil/v4 to v4.25.3 [`#749`](yorukot/superfile#749) by [@&#8203;renovate](https://github.com/renovate)
-   fix(deps): update module github.com/pelletier/go-toml/v2 to v2.2.4 [`#760`](yorukot/superfile#760) by [@&#8203;renovate](https://github.com/renovate)
-   fix(deps): update module github.com/alecthomas/chroma/v2 to v2.16.0 [`#751`](yorukot/superfile#751) by [@&#8203;renovate](https://github.com/renovate)
-   fix(deps): update dependency sharp to ^0.34.0 [`#755`](yorukot/superfile#755) by [@&#8203;renovate](https://github.com/renovate)
-   fix(deps): update dependency [@&#8203;astrojs/starlight](https://github.com/astrojs/starlight) to ^0.34.0 [`#761`](yorukot/superfile#761) by [@&#8203;renovate](https://github.com/renovate)

</p>
</details> 

#### New Contributors
* @&#8203;Rocco-Gossmann made their first contribution in yorukot/superfile#736
* @&#8203;Frost-Phoenix made their first contribution in yorukot/superfile#828

**Full Changelog**: yorukot/superfile@v1.2.1...v1.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4yMi4wIiwidXBkYXRlZEluVmVyIjoiNDAuMjMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation high priority Issue/PR/Feature/bug that is considered high priority. new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants