fix: Correctly resolve path in open and cd prompt actions

[lazysegtree]

Summary by CodeRabbit

• Refactor
  • Improved handling of directory paths and path resolution for file panels, enhancing clarity and consistency when opening or navigating panels.
  • Simplified and unified path normalization and tilde expansion logic.
• New Features
  • Introduced a utility for resolving and normalizing file paths, including support for ~ expansion.
• Bug Fixes
  • Improved error handling for invalid or inaccessible directories when configuring start directories.
• Tests
  • Added tests to verify correct path resolution and normalization behavior.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a new utility function for resolving and normalizing file paths, refactor internal logic to use this function, and update error handling and path resolution in directory-related operations. A new test suite is added for the utility function, and some internal methods are split for clarity. Minor comments and unused imports are also addressed.

Changes

File(s)	Change Summary
src/internal/utils/file_utils.go	Added ResolveAbsPath utility function for absolute path resolution and tilde expansion.
src/internal/utils/file_utils_test.go	Introduced tests for ResolveAbsPath covering normalization, tilde expansion, and relative/absolute path handling.
src/internal/config_function.go	Refactored directory path resolution to use ResolveAbsPath, updated error handling for non-existent paths, improved debug logging, and removed unused imports.
src/internal/model.go	Split directory update logic into creteNewFilePanelRelativeToCurrent and a revised updateCurrentFilePanelDir. Updated usage and error messages for clarity and consistency.
src/internal/handle_panel_navigation.go	Added a TODO comment to define a specific error constant for file panel limits. No logic changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Model
    participant Utils

    User->>Model: Request to open new file panel (relative path)
    Model->>Utils: ResolveAbsPath(currentDir, path)
    Utils-->>Model: Absolute, cleaned path
    Model->>Model: Check if path exists and is directory
    Model-->>User: Success or error response

Loading

Poem

In the warren where paths intertwine,
A rabbit hops, making each line fine.
Tilde expands, slashes are cleaned,
With tests to ensure all bugs are gleaned.
Panels open wide, errors now defined—
In this patch, neat code is enshrined!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lazysegtree]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54aee46 and 3e8e9b4.

📒 Files selected for processing (5)

• src/internal/config_function.go (1 hunks)
• src/internal/handle_panel_navigation.go (1 hunks)
• src/internal/model.go (2 hunks)
• src/internal/utils/file_utils.go (2 hunks)
• src/internal/utils/file_utils_test.go (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (3)

src/internal/utils/file_utils_test.go (1)

src/internal/utils/file_utils.go (1)

• ResolveAbsPath (105-115)

src/internal/config_function.go (3)

src/internal/common/default_config.go (1)

• Config (11-11)

src/internal/utils/file_utils.go (1)

• ResolveAbsPath (105-115)

src/config/fixed_variable.go (1)

• HomeDir (27-27)

src/internal/model.go (1)

src/internal/utils/file_utils.go (1)

• ResolveAbsPath (105-115)

🔇 Additional comments (7)

src/internal/utils/file_utils.go (1)

101-115: Well implemented utility function for path resolution!

The new ResolveAbsPath utility function correctly handles path resolution, including tilde expansion, relative path resolution, and path cleaning. The implementation follows good practices by:

1. Clearly documenting the function purpose and expectations
2. Handling edge cases appropriately (tilde expansion, relative vs absolute paths)
3. Using standard library functions for path manipulation
4. Avoiding dependencies that could create circular references (using xdg.Home directly)

src/internal/handle_panel_navigation.go (1)

28-29: Good suggestion to centralize error definitions.

Centralizing error definitions in a dedicated errors.go file would improve maintainability and allow for better error handling throughout the application.

src/internal/config_function.go (2)

57-69: Excellent refactoring of path resolution logic.

The refactoring simplifies the code by:

1. Getting the current working directory once instead of repeatedly
2. Using the new ResolveAbsPath utility function for consistent path handling
3. Improving error handling by checking path existence with os.Stat
4. Providing a clean fallback to home directory when paths are invalid

This centralizes path resolution logic and makes the code more maintainable.

---

72-72: Improved debug logging.

Adding the current working directory to the debug log provides more context for troubleshooting path resolution issues.

src/internal/utils/file_utils_test.go (1)

10-60: Comprehensive test coverage for the new utility function.

The test cases are well-designed and cover key scenarios:

1. Path cleaning (removing redundant slashes)
2. Resolving relative paths against a current directory
3. Preserving absolute paths
4. Handling tilde expansion
5. Ensuring tilde is only expanded when it appears at the beginning of the path

Each test case has a clear name that describes its purpose, making the tests self-documenting.

src/internal/model.go (2)

316-316: Function call correctly updated to use new path resolution method.

The call to create a new file panel has been updated to use creteNewFilePanelRelativeToCurrent which properly resolves paths relative to the current panel's directory.

---

353-365: Improved path resolution in CD action.

The updateCurrentFilePanelDir function now correctly resolves paths relative to the current directory using utils.ResolveAbsPath, which handles tilde expansion and relative paths. The error messages are also clear and helpful.