Theme: Add gruvbox-dark-hard #828
Conversation
WalkthroughA new theme configuration file, Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/superfile_config/theme/gruvbox-dark-hard.toml (2)
1-6: Grammar and clarity in header comments
There are a few minor typos and consistency issues in the comment block:
- Change “Theme create by:” to “Theme created by:”
- Complete or remove the “Update by(sort by time):” line since it’s empty
- Change “Thanks for all contributor!!” to “Thanks to all contributors!”
43-45: Improve gradient_color comment
- Grammar: change “can only have two color!” to “can only have two colors.”
- Consider aligning its header style (e.g.,
# ========= Gradient (two colors) =========) to match other sections.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
src/superfile_config/theme/gruvbox-dark-hard.toml(1 hunks)
🔇 Additional comments (9)
src/superfile_config/theme/gruvbox-dark-hard.toml (9)
10-10: Confirm code_syntax_highlight value
The style is set to"gruvbox". Please verify that this matches the intended Chroma style name (e.g. if you meant a distinct"gruvbox-dark-hard"style) or update as needed.
12-16: Border color definitions look consistent
The border colors follow the Gruvbox Dark Hard palette and adhere to the existing naming conventions. No issues found.
17-22: Active border colors are well-defined
Good contrast between inactive and active states; these values fit the “hard” variant.
23-29: Background colors are consistent
All background elements share the same base (#1D2021), which is typical for a cohesive dark theme.
30-36: Foreground (fg) settings look good
Using#FBF1C7across all foreground elements ensures readability against the dark background.
49-51: Verify empty background values in File Panel
file_panel_item_selected_bgis set to an empty string. Confirm that the config loader treats this as “no background” rather than producing a parse error. If not, consider removing the key or providing a default.
53-56: Verify empty sidebar background value
Similarly,sidebar_item_selected_bgis empty. Ensure the parser handles empty strings gracefully or supply a fallback color if needed.
59-63: Verify empty modal background values
Bothmodal_cancel_bgandmodal_confirm_bgare empty. Please check that empty strings are valid in your TOML loader; otherwise, remove these keys or add defaults.
66-68: Help Menu styling approved
The hotkey (#689D6A) and title (#B16286) colors fit well with the palette and maintain consistency.
|
@Frost-Phoenix To prevent theme issues, we are adding these instruction for theme PRs. Please add these screenshots in the PR, to make sure that the theme doesn't have any issues
Example
|
|
@Frost-Phoenix What are the major points where it differs from gruvbox ? |
It is a variant of the same theme with a similar "atmosphere" but features different colors, mainly with higher contrast. This is comparable to the different Catppuccin variants (Mocha, Macchiato, Frappé, and Latte). Here are both themes side by side:
I understand if you think it’s not different enough to be included in the theme list. ScreenshotsFull view of superfile
Sidebar panel
Processes panel
Help menu
New file popup
Image preview
About the shell commands, I dind't find how to open the dialog, what is the keybind to open it? |
|
@Frost-Phoenix Thanks. This looks different enough. Its has an "actual dark theme" vibe. For shell panel you would build the branch from latest main. |
Here - Screenshots for shell |
|
This looks good. Please also add a file for this in and update the list in website/src/content/docs/list/theme-list.md refer to this |
Done! Thanks for your review. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
website/src/content/docs/list/theme-list.md (2)
85-87: Convert bare URLs to markdown links
To satisfy markdownlint’s MD034 rule and improve readability, wrap the GitHub URLs in link syntax. For example:- - Ported by: https://github.com/frost-phoenix + - Ported by: [frost-phoenix](https://github.com/frost-phoenix) - - Original Author: https://github.com/morhetz/ + - Original Author: [morhetz](https://github.com/morhetz/)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
86-86: Bare URL used
null(MD034, no-bare-urls)
87-87: Bare URL used
null(MD034, no-bare-urls)
89-89: Add descriptive alt text to the theme preview image
Markdownlint MD045 flags images without alt text. Including a short description improves accessibility:-  + 🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
89-89: Images should have alternate text (alt text)
null(MD045, no-alt-text)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
asset/theme/gruvbox-dark-hard.pngis excluded by!**/*.png
📒 Files selected for processing (1)
website/src/content/docs/list/theme-list.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
website/src/content/docs/list/theme-list.md
86-86: Bare URL used
null
(MD034, no-bare-urls)
87-87: Bare URL used
null
(MD034, no-bare-urls)
89-89: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
🔇 Additional comments (1)
website/src/content/docs/list/theme-list.md (1)
83-90:✅ Verification successful
Verify that the new theme asset and config file are present
Ensure the repository includes both thegruvbox-dark-hard.tomlconfiguration and the corresponding screenshot underasset/theme/. You can run:
🏁 Script executed:
#!/bin/bash # Verify theme config and preview image were added fd --type f gruvbox-dark-hard.toml fd --type f gruvbox-dark-hard.pngLength of output: 156
Verification Complete: Theme Assets Present
Both the configuration file and preview image for “gruvbox-dark-hard” have been added:
- src/superfile_config/theme/gruvbox-dark-hard.toml
- asset/theme/gruvbox-dark-hard.png
No further action required.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
86-86: Bare URL used
null(MD034, no-bare-urls)
87-87: Bare URL used
null(MD034, no-bare-urls)
89-89: Images should have alternate text (alt text)
null(MD045, no-alt-text)
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [yorukot/superfile](https://github.com/yorukot/superfile) | minor | `v1.2.1` -> `v1.3.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>yorukot/superfile (yorukot/superfile)</summary> ### [`v1.3.0`](https://github.com/yorukot/superfile/releases/tag/v1.3.0) [Compare Source](yorukot/superfile@v1.2.1...v1.3.0) We are excited to release v1.3.0 for superfile, with new features, key bug fixes, and lots of polish under the hood. #### Install: [**Click me to know how to install**](https://github.com/yorukot/superfile?tab=readme-ov-file#installation) #### Highlights - We have revamped the command prompt and added built-in commands for SuperFile-specific actions. Check out yorukot/superfile#745 - Multi-panel startup support. You can now open multiple panels right from startup, making your workflow even more efficient. - Added new configurations : --chooser-file option, show_panel_footer_info config flag and many command prompt specific flags. #### Improvements & Fixes - The sidebar code was refactored and separated for better maintainability and various linter fixes and CI/CD improvements were made to keep the codebase clean and robust. - A new Rendering package is implemented, centralising border, content, and section rendering logic into reusable renderer components, fixing many layout bugs. - Model behaviour, file operations and rendering-related unit tests were added to improve test coverage. #### Detailed Change Summary <details><summary>Details</summary> <p> #### New Features - Added a Command-Prompt for SuperFile specific actions [`#752`](yorukot/superfile#752) by [@​Rocco-Gossmann](https://github.com/Rocco-Gossmann), [@​yorukot](https://github.com/yorukot) and [@​lazysegtree](https://github.com/lazysegtree) - Allow specifying multiple panels at startup [`#759`](yorukot/superfile#759) by [@​lazysegtree](https://github.com/lazysegtree) - Initial draft of rendering package [`#775`](yorukot/superfile#775) by [@​lazysegtree](https://github.com/lazysegtree) - Render unit tests for prompt model [`#809`](yorukot/superfile#809) by [@​lazysegtree](https://github.com/lazysegtree) - Chooser file option, --lastdir-file option, and improvements in quit, and bug fixes [`#812`](yorukot/superfile#812) by [@​lazysegtree](https://github.com/lazysegtree) - Prompt feature leftover items [`#804`](yorukot/superfile#804) by [@​lazysegtree](https://github.com/lazysegtree) - SPF Prompt tutorial and fixes [`#814`](yorukot/superfile#814) by [@​lazysegtree](https://github.com/lazysegtree) - Write prompt tutorial, rename prompt mode to spf mode, add develop branch in GitHub workflow, show_panel_footer_info flag [`#815`](yorukot/superfile#815) by [@​lazysegtree](https://github.com/lazysegtree) - Theme: Add gruvbox-dark-hard [`#828`](yorukot/superfile#828) by [@​Frost-Phoenix](https://github.com/Frost-Phoenix) #### Updates & Improvements - Sidebar separation [`#767`](yorukot/superfile#767) by [@​lazysegtree](https://github.com/lazysegtree) - Sidebar code separation [`#770`](yorukot/superfile#770) by [@​lazysegtree](https://github.com/lazysegtree) - Rendering package and rendering bug fixes [`#781`](yorukot/superfile#781) by [@​lazysegtree](https://github.com/lazysegtree) - Refactor CheckForUpdates [`#797`](yorukot/superfile#797) by [@​JassonCordones](https://github.com/JassonCordones) - Rename metadata strings [`#731`](yorukot/superfile#731) by [@​booth-w](https://github.com/booth-w) #### Bug Fixes - Fix crash with opening file with editor on an empty panel [`#730`](yorukot/superfile#730) by [@​booth-w](https://github.com/booth-w) - Fix: Add some of the remaining linter and fix errors [`#756`](yorukot/superfile#756) by [@​lazysegtree](https://github.com/lazysegtree) - Golangci lint fixes [`#757`](yorukot/superfile#757) by [@​lazysegtree](https://github.com/lazysegtree) - Fix: Remove redundant function containsKey [`#765`](yorukot/superfile#765) by [@​lazysegtree](https://github.com/lazysegtree) - Fix: Correctly resolve path in open and cd prompt actions [`#802`](yorukot/superfile#802) by [@​lazysegtree](https://github.com/lazysegtree) - Prompt dynamic dimensions and unit tests fix [`#805`](yorukot/superfile#805) by [@​lazysegtree](https://github.com/lazysegtree) - Fix: Convert unicode space to normal space, use rendered in file preview to fix layout bugs, Release 1.3.0 [`#825`](yorukot/superfile#825) by [@​lazysegtree](https://github.com/lazysegtree) #### Optimization & Code Quality - Adding linter to CI/CD and fix some lint issues [`#739`](yorukot/superfile#739) by [@​lazysegtree](https://github.com/lazysegtree) - Linter fixes, new feature of allowing multiple directories at startup, other code improvements [`#764`](yorukot/superfile#764) by [@​lazysegtree](https://github.com/lazysegtree) - Model unit tests [`#803`](yorukot/superfile#803) by [@​lazysegtree](https://github.com/lazysegtree) #### Dependency Updates - fix(deps): update dependency astro to v5.7.7 [`#726`](yorukot/superfile#726) by [@​renovate](https://github.com/renovate) - fix(deps): update module github.com/shirou/gopsutil/v4 to v4.25.3 [`#749`](yorukot/superfile#749) by [@​renovate](https://github.com/renovate) - fix(deps): update module github.com/pelletier/go-toml/v2 to v2.2.4 [`#760`](yorukot/superfile#760) by [@​renovate](https://github.com/renovate) - fix(deps): update module github.com/alecthomas/chroma/v2 to v2.16.0 [`#751`](yorukot/superfile#751) by [@​renovate](https://github.com/renovate) - fix(deps): update dependency sharp to ^0.34.0 [`#755`](yorukot/superfile#755) by [@​renovate](https://github.com/renovate) - fix(deps): update dependency [@​astrojs/starlight](https://github.com/astrojs/starlight) to ^0.34.0 [`#761`](yorukot/superfile#761) by [@​renovate](https://github.com/renovate) </p> </details> #### New Contributors * @​Rocco-Gossmann made their first contribution in yorukot/superfile#736 * @​Frost-Phoenix made their first contribution in yorukot/superfile#828 **Full Changelog**: yorukot/superfile@v1.2.1...v1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4yMi4wIiwidXBkYXRlZEluVmVyIjoiNDAuMjMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
2 participants
Hello, I made a
dark-hardversion of the existinggruvboxtheme.This is not a completely new theme, but I think it is different enough from the existing
gruvboxtheme to be relevant.I really would like to get your opinion on this and on the theme itself.
Summary by CodeRabbit