feat: Render unit tests for prompt model

[lazysegtree]

Summary by CodeRabbit

• Tests

  • Added comprehensive tests to validate the visual output and behavior of the prompt UI under various scenarios, including input handling, suggestion lists, and result messages.
  • Renamed an existing test function for clarity.

• Chores

  • Simplified global configuration initialization in tests by updating how configuration files are loaded.

[coderabbitai]

Walkthrough

The changes update the way global configuration files are loaded by making the path resolution internal to the PopulateGlobalConfigs function, removing the need for external path parameters. Related test files are updated to use the new function signature. Additionally, prompt UI model tests are expanded with detailed rendering checks and a function is renamed for clarity.

Changes

File(s)	Change Summary
src/internal/common/load_config.go	Refactored PopulateGlobalConfigs to resolve config file paths internally using runtime.Caller and removed its parameters. Function signature changed accordingly.
src/internal/model_test.go	Updated to call common.PopulateGlobalConfigs() with no arguments, removing dynamic path logic and the "runtime" import. Error handling and setup remain unchanged.
src/internal/ui/prompt/model_test.go	Enhanced tests with new imports and a comprehensive TestModel_Render function that checks prompt rendering in various scenarios. Renamed TestMode_HandleResults to TestModel_HandleResults. Updated global init logic.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Code
    participant Common as PopulateGlobalConfigs
    participant FS as File System

    Test->>Common: PopulateGlobalConfigs()
    Common->>FS: Determine current file location (runtime.Caller)
    Common->>FS: Traverse up directories to config root
    Common->>FS: Build paths for config, hotkeys, theme files
    Common->>Common: Load configs from constructed paths
    Common-->>Test: Return error or success

Loading

Poem

In burrows deep, configs once passed,
Now found within—no need to ask!
Tests now simpler, paths unseen,
Prompt UI shines, crisp and clean.
With every render, rabbits cheer,
For tidy code and output clear!
🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec16805 and fb7c8f9.

📒 Files selected for processing (3)

• src/internal/common/load_config.go (2 hunks)
• src/internal/model_test.go (1 hunks)
• src/internal/ui/prompt/model_test.go (4 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/internal/model_test.go (1)

src/internal/common/load_config.go (1)

• PopulateGlobalConfigs (238-262)

🔇 Additional comments (5)

src/internal/common/load_config.go (1)

238-248: Well-implemented refactoring of configuration path resolution.

The refactoring effectively centralizes the path resolution logic within the PopulateGlobalConfigs function, making it more self-contained and easier to use. Using runtime.Caller(0) to determine the source file location is a common and effective approach for locating configuration files relative to the code.

src/internal/model_test.go (1)

38-38: Code simplification aligns with the refactored function signature.

The update correctly calls the refactored PopulateGlobalConfigs() function without parameters, which now internally determines the configuration file paths. This simplifies the test setup while maintaining the same functionality.

src/internal/ui/prompt/model_test.go (3)

20-30: Updated global initialization with proper error handling.

The changes to initGlobals() correctly call the refactored PopulateGlobalConfigs() function and include proper error handling. The comments accurately reflect the need to find a better solution for test configuration in the future.

---

176-176: Function name corrected from TestMode_HandleResults to TestModel_HandleResults.

This change fixes a typo in the function name, making it consistent with the naming convention for test functions.

---

218-414: Comprehensive test coverage for the prompt model's rendering functionality.

The newly added TestModel_Render function provides excellent test coverage for the prompt model's rendering, including:

1. Basic rendering in different modes
2. User input handling with special characters and truncation
3. Result message display
4. Dynamic suggestion lists based on user input

The tests use ansi.Strip to remove ANSI escape codes, enabling reliable string comparison, and the assertions thoroughly verify both the structure and content of the rendered output.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lazysegtree]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[lazysegtree]

@coderabbitai
Please generate a task description for this PR. I will give someone this task. He doesn't know anything about this product. We have prompt modal that user use to run shell commands and internal spf commands

Now we are adding a unit tests for this.

• Populate global configs from the superfile_config files as done in model_test.go
• Write thorough tests for rendering of prompt modal
• Cover dimensions, content, trimming of user input based on width, rendering of correct suggestion, etc
  Add Anything else that I missed, which is done in this PR, and should be in the ask description.

Keep it in 6-7 points or less. Format should be markdown. Make sure to highlight what needs to be done, not how or where. Write it in a way that a LLM could generate a correct PR for it.

Give basic context about Superfile and what the requirements are.The problem description should be stated such that a reasonably competent software engineer could write the correct PR for it without too much familiarity with the repo

Also, generate a TL;DR

[coderabbitai]

@lazysegtree, here's a comprehensive task description for this PR:

Task Description: Add Unit Tests for Prompt Modal Rendering

Context

Superfile is a terminal-based file manager that includes a prompt modal interface allowing users to execute both shell commands and internal superfile (spf) commands. The prompt modal provides an interactive command-line experience with features like auto-suggestions, input validation, and visual feedback for command execution results.

Requirements

• Simplify test configuration setup by refactoring the global config population function to automatically determine configuration file paths instead of requiring explicit parameters

• Implement comprehensive rendering tests for the prompt modal that verify the visual output structure, including box-drawing characters, borders, and layout consistency across different UI states

• Test user input handling and display including input truncation based on available width, proper handling of special characters and emojis, and ensuring the visible input line respects terminal width constraints

• Verify mode-specific rendering behavior for both shell command mode and internal spf command mode, ensuring each displays appropriate prompt characters and mode-specific UI hints

• Test suggestion system rendering by validating that auto-complete suggestions appear correctly for various input scenarios including partial commands, commands with arguments, and handling of invalid/unknown commands

• Test result message display for both successful command execution and error states, ensuring proper formatting and visibility of success/failure feedback messages

• Ensure ANSI escape code handling by stripping terminal formatting codes during test assertions to enable reliable string comparisons and content verification

TL;DR

Add comprehensive unit tests for the prompt modal's rendering functionality, covering input display, suggestions, result messages, and UI layout across different modes while simplifying the test configuration setup.

---

🧠 Learnings used

Learnt from: lazysegtree
PR: yorukot/superfile#950
File: src/internal/ui/metadata/README.md:7-7
Timestamp: 2025-07-24T03:46:29.516Z
Learning: lazysegtree prefers to defer comprehensive unit testing to separate PRs when the current PR has grown too large, maintaining focus on the primary refactoring objectives while tracking testing requirements in dedicated GitHub issues.

---

Learnt from: lazysegtree
PR: yorukot/superfile#1011
File: src/internal/handle_modal.go:145-203
Timestamp: 2025-08-29T13:56:33.955Z
Learning: lazysegtree identified that help menu navigation functions (helpMenuListUp and helpMenuListDown) in src/internal/handle_modal.go are too complicated, can be simplified, are similar to sidebar navigation but inconsistent, and lack unit tests. He prefers to track such technical debt in separate GitHub issues rather than addressing it in the current PR scope.

---

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/default_config.go:16-16
Timestamp: 2025-07-27T07:40:51.938Z
Learning: lazysegtree prefers simpler implementation approaches when the alternatives are significantly more complex, even if the alternatives might be architecturally cleaner, prioritizing maintainability and avoiding over-engineering.

---

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/default_config.go:16-16
Timestamp: 2025-07-27T07:40:51.938Z
Learning: lazysegtree prefers simpler implementation approaches when the alternatives are significantly more complex, even if the alternatives might be architecturally cleaner, prioritizing maintainability and avoiding over-engineering.

---

Learnt from: lazysegtree
PR: yorukot/superfile#969
File: src/internal/key_function.go:40-40
Timestamp: 2025-08-03T09:34:55.721Z
Learning: lazysegtree emphasizes proper dependency direction in software architecture, preferring that low-level components (like modal handlers) should not depend on high-level components (like the main model object). He also prioritizes performance considerations, noting that creating objects on every keypress in hot code paths like key handling is inefficient and should be avoided.

---

Learnt from: lazysegtree
PR: yorukot/superfile#1013
File: src/internal/model_render.go:329-341
Timestamp: 2025-08-29T14:11:21.380Z
Learning: lazysegtree prefers to defer help menu rendering optimizations and other technical debt improvements to separate GitHub issues when the current PR scope has grown too large, maintaining focus on the primary refactoring objectives while tracking performance improvements for future work.

---

Learnt from: lazysegtree
PR: yorukot/superfile#985
File: src/internal/model.go:0-0
Timestamp: 2025-08-11T01:49:30.040Z
Learning: lazysegtree prefers maintaining code correctness through proper design and invariants rather than adding defensive bounds checks at every slice access point, viewing such defensive programming as "duct taping" that can mask actual bugs instead of fixing them at their source.

---

Learnt from: lazysegtree
PR: yorukot/superfile#973
File: src/internal/ui/processbar/model_update.go:7-27
Timestamp: 2025-08-03T14:49:31.221Z
Learning: lazysegtree prefers to keep test-only code simple without adding production-level concerns like goroutine synchronization, cancellation contexts, or complex lifecycle management, even when such patterns might prevent potential issues, since the complexity isn't justified for test utilities.

---

Learnt from: lazysegtree
PR: yorukot/superfile#1044
File: src/internal/utils/file_utils.go:149-149
Timestamp: 2025-09-09T13:29:11.771Z
Learning: lazysegtree prefers to keep PR scope focused on the primary objectives and considers pre-existing technical debt issues as out of scope for migration/refactoring PRs, preferring to defer such issues to separate GitHub issues rather than expanding the current PR scope.

---

Learnt from: lazysegtree
PR: yorukot/superfile#967
File: src/internal/key_function.go:45-47
Timestamp: 2025-08-02T11:47:07.713Z
Learning: lazysegtree prefers to track technical debt and architectural improvements in dedicated GitHub issues when they are identified during PR reviews but are beyond the scope of the current PR, particularly for complex refactoring needs like input handling architecture that would require significant changes.

---

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/handle_file_operations.go:567-570
Timestamp: 2025-07-27T08:49:09.687Z
Learning: lazysegtree prefers to defer technical debt issues like model mutation concerns to later PRs when the current PR has already grown too large, maintaining focus on the primary objectives while acknowledging the need to track such issues for future work.