fix: remove redundant function containsKey

[lazysegtree]

Summary by CodeRabbit

• Refactor
  • Streamlined key input handling for more efficient and reliable command processing, ensuring a swift response to user actions.

[lazysegtree]

@coderabbitai review

[coderabbitai]

Walkthrough

This pull request refactors key command checks by removing the custom containsKey function. Its previous usage in multiple methods is replaced with direct calls to slices.Contains, thereby streamlining the logic. Additionally, an import for the slices package is added in the model, specifically within the handleKeyInput method, to directly validate key inputs.

Changes

File(s)	Change Summary
src/internal/key_function.go	Removed the containsKey function and updated various key-checking methods (mainKey, normalAndBrowserModeKey, etc.) to use slices.Contains directly.
src/internal/model.go	Modified handleKeyInput to directly use slices.Contains for quit key detection and added the slices package import.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Model
    participant Slices

    User->>Model: Sends key input
    Model->>Slices: Invoke slices.Contains(key, validKeys)
    Slices-->>Model: Return boolean result
    Model->>Model: Process input based on result

Loading

Possibly related PRs

• fix: remove redundant function containsKey #762: This PR also removed the containsKey function and replaced its usage with slices.Contains in key checking, aligning closely with the changes made here.

Suggested labels

refactoring

Poem

I'm a bunny hopping 'cross the code,
Leaving old functions in the road.
With slices.Contains as my new guide,
My logic's clear, no need to hide.
I nibble on clean code with delight,
Celebrating refactoring, byte by byte!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d69cc95 and 025753d.

📒 Files selected for processing (2)

• src/internal/key_function.go (7 hunks)
• src/internal/model.go (2 hunks)

🧰 Additional context used

🧬 Code Definitions (2)

src/internal/key_function.go (3)

src/internal/common/default_config.go (1)

• Hotkeys (12-12)

src/config/fixed_variable.go (3)

• HomeDir (27-27)
• ToggleDotFile (41-41)
• ToggleFooter (42-42)

src/config/icon/icon.go (2)

• ExtractFile (25-25)
• CompressFile (24-24)

src/internal/model.go (1)

src/internal/common/default_config.go (1)

• Hotkeys (12-12)

🔇 Additional comments (10)

src/internal/model.go (2)

11-11: Good addition of slices package.

Adding the slices package from the standard library is a good choice for replacing the custom containsKey function. The standard library offers well-tested implementations for common operations.

---

266-266: Clean replacement of containsKey with slices.Contains.

The change from containsKey(msg.String(), common.Hotkeys.Quit) to slices.Contains(common.Hotkeys.Quit, msg.String()) properly replaces the custom function with the standard library equivalent while correctly reversing the argument order.

src/internal/key_function.go (8)

17-138: Good refactoring of multiple key command checks in mainKey.

The changes consistently replace all occurrences of containsKey(msg, array) with slices.Contains(array, msg) throughout the mainKey function. This maintains the same functionality while leveraging the standard library implementation.

---

144-202: Clean replacement in normalAndBrowserModeKey function.

All key checks in this function have been correctly updated to use slices.Contains with the appropriate argument order.

---

205-212: Consistent refactoring in typingModalOpenKey.

The key command checks in this function have been properly updated to use slices.Contains.

---

216-255: Properly refactored warnModalOpenKey function.

All occurrences of the custom containsKey function have been correctly replaced with slices.Contains in this function.

---

258-269: Well-updated confirmToQuitSuperfile function.

The key checks in this function have been appropriately refactored to use slices.Contains.

---

272-285: Good refactoring in sortOptionsKey function.

All key command checks have been properly updated to use the standard library function.

---

287-298: Clean refactoring in remaining key handling functions.

The remaining key handling functions (renamingKey, sidebarRenamingKey, sidebarSearchBarKey, focusOnSearchbarKey, helpMenuKey) have all been properly updated to use slices.Contains with the correct argument order.

Also applies to: 300-307, 309-318, 321-328, 332-341

---

3-11:

✅ Verification successful

Verify slices package compatibility with your Go version.

The PR uses the slices package which was introduced in Go 1.21. Ensure your project's minimum Go version is compatible.

---

🏁 Script executed:

#!/bin/bash
# Check Go version in go.mod file
grep -E "^go [0-9]+\.[0-9]+" go.mod

Length of output: 47

---

Slices package compatibility verified.

Your project's minimum Go version is set to 1.24.1, which fully supports the slices package (introduced in Go 1.21). No further action is necessary regarding this import.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.