Skip to content

Leftover items in spf prompt feature. #753

@lazysegtree

Description

@lazysegtree

Creating this issue to track additional work needed to consider the spf prompt feature complete.

Fixes

  • Fix cd //////, open ////, also open not working with relative paths.
  • config file validation should not use slog.Error

Functionality

  • Consider sanitizing and showing shell command output to the user - Not doing now

UI

  • Stabilize Prompt Rendering code, and handle resize, special char inputs, long inputs
  • Superfile file prompt should appear in the middle of the whole terminal (vertically)

Testing

  • Add testsuite for prompt model - Already covered in one testsuite test
  • Complete remaining testcases in modal_prompt_test.go

Cross Platform-ness

Tests are flaky, in my slow windows VM, but I see that the feature work. One day we might want to fix them

Documentation

Initial PR - #752

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthigh priorityIssue/PR/Feature/bug that is considered high priority.new feature

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions