-
-
Notifications
You must be signed in to change notification settings - Fork 414
Closed
Labels
enhancementNew feature or requestNew feature or requesthigh priorityIssue/PR/Feature/bug that is considered high priority.Issue/PR/Feature/bug that is considered high priority.new feature
Milestone
Description
Creating this issue to track additional work needed to consider the spf prompt feature complete.
Fixes
- Fix
cd //////,open ////, alsoopennot working with relative paths. - config file validation should not use slog.Error
Functionality
- Consider sanitizing and showing shell command output to the user - Not doing now
UI
- Stabilize Prompt Rendering code, and handle resize, special char inputs, long inputs
- Superfile file prompt should appear in the middle of the whole terminal (vertically)
Testing
- Add testsuite for prompt model - Already covered in one testsuite test
- Complete remaining testcases in modal_prompt_test.go
Cross Platform-ness
Tests are flaky, in my slow windows VM, but I see that the feature work. One day we might want to fix them
-
Fix environment variable substitution on windows -
-
Fix unit tests for windows
Documentation
- Add proper info about this spf website along with screenshots
Initial PR - #752
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthigh priorityIssue/PR/Feature/bug that is considered high priority.Issue/PR/Feature/bug that is considered high priority.new feature