Skip to content

Do not call name() on rpitit assoc_item #141308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Do not call name() on rpitit assoc_item #141308

merged 1 commit into from
May 21, 2025
+35 −11

Conversation

spastorino
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2025
@spastorino spastorino added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 20, 2025
@spastorino
Copy link
Member Author

beta-nominated as this is a beta regression. Not a big deal but somebody seems to have hit this in the wild #141143

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@spastorino spastorino force-pushed the fix-rpitit-error-reporting-ice branch from 5b96c21 to 66d47c1 Compare May 20, 2025 20:30
@nnethercote
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented May 21, 2025

📌 Commit 66d47c1 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request May 21, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
@bors
Auto merge of rust-lang#141320 - matthiaskrgr:rollup-ag3vf3a, r=matth…
bbd3a5a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#140981 (Add match guard let chain drop order and scoping tests)
 - rust-lang#141042 (ci: split powerpc64le-linux job)
 - rust-lang#141078 (ci: split dist-arm-linux job)
 - rust-lang#141222 (Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`.)
 - rust-lang#141308 (Do not call name() on rpitit assoc_item)
 - rust-lang#141316 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1b3159a into rust-lang:master May 21, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 21, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
@rust-timer
Unrolled build for rust-lang#141308
5563644 
Rollup merge of rust-lang#141308 - spastorino:fix-rpitit-error-reporting-ice, r=nnethercote

Do not call name() on rpitit assoc_item

Fixes rust-lang#141143

r? `@nnethercote`
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip and here. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 22, 2025
@cuviper cuviper mentioned this pull request May 22, 2025
Open
@cuviper cuviper modified the milestones: 1.89.0, 1.88.0 May 22, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 22, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2025
@bors
Auto merge of rust-lang#141412 - cuviper:beta-next, r=cuviper
343190f 
[beta] backports and stage0 bump

- bump stage0
- Update the edition guide for let chains rust-lang#140852
- Fix download of GCC from CI on non-nightly channels rust-lang#140901
- Revert "Fix linking statics on Arm64EC rust-lang#140176" rust-lang#141024
- [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test rust-lang#141045
- Do not call name() on rpitit assoc_item rust-lang#141308

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

ICE: name of non-Rpitit assoc item
7 participants
@spastorino @rust-log-analyzer @nnethercote @bors @apiraino @cuviper @rustbot