Add match guard let chain drop order and scoping tests #140981
Merged
+269
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on tests/ui/rfcs/rfc-2497-if-let-chains/temporary-early-drop.rs
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
8 tasks
|
@bors r+ |
bors
added
S-waiting-on-bors
5 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#140981 (Add match guard let chain drop order and scoping tests) - rust-lang#141042 (ci: split powerpc64le-linux job) - rust-lang#141078 (ci: split dist-arm-linux job) - rust-lang#141222 (Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`.) - rust-lang#141308 (Do not call name() on rpitit assoc_item) - rust-lang#141316 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2025
Rollup merge of rust-lang#140981 - est31:guard_let_chains_tests, r=petrochenkov Add match guard let chain drop order and scoping tests We have a bunch of tests for if let chain drop order, but those tests don't cover match guard chains to the same depth. This PR adds the following tests: * match guard equivalents of the if let chains tests in the `drop-order-comparisons.rs` test, added by rust-lang#133605. * match guard equivalent of the `mir_let_chains_drop_order.rs` test, added by rust-lang#107251 * match guard equivalent of `temporary-early-drop.rs`, added by rust-lang#133093 The added tests all have variants for 2021 and 2024, showing that the behavior on both editions matches that of if let chains on 2024. tracking issue: rust-lang#51114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of tests for if let chain drop order, but those tests don't cover match guard chains to the same depth. This PR adds the following tests:
drop-order-comparisons.rstest, added by Add extensive set of drop order tests #133605.mir_let_chains_drop_order.rstest, added by Rescope temp lifetime in if-let into IfElse with migration lint #107251temporary-early-drop.rs, added by Let chains tests #133093The added tests all have variants for 2021 and 2024, showing that the behavior on both editions matches that of if let chains on 2024.
tracking issue: #51114