Implement ptr::try_cast_aligned and NonNull::try_cast_aligned.
#141222
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This was referenced May 18, 2025
rustbot
added
T-libs-api
This comment has been minimized.
This comment has been minimized.
|
|
|
r? libs-api |
tgross35
reviewed
May 20, 2025
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
mathisbot
force-pushed
the
ptr_trycastaligned
branch
from
8cb6727 to
bb6afec
Compare
rustbot
removed
has-merge-commits
tgross35
approved these changes
May 20, 2025
There was a problem hiding this comment.
Changes lgtm but would you mind cleaning up the commit message? It's a bit nonsensical (assuming this came from an autosquash)
Implement `ptr::try_cast_aligned`
`ptr::try_cast_aligned`: link tracking issue
`ptr::try_cast_aligned`: remove forgotten `const`
`NonNull::try_cast_aligned`: fix doctest
`ptr::try_cast_aligned`: #[inline]
ptr::`try_cast_aligned`: fix doc
Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`.
You should just be able to run git commit --amend and delete everything but the first (or last) line, then git push --force-with-lease.
mathisbot
force-pushed
the
ptr_trycastaligned
branch
from
bb6afec to
9d1cf12
Compare
|
Did it work this time ? 😅 |
|
Great, thank you! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#140981 (Add match guard let chain drop order and scoping tests) - rust-lang#141042 (ci: split powerpc64le-linux job) - rust-lang#141078 (ci: split dist-arm-linux job) - rust-lang#141222 (Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`.) - rust-lang#141308 (Do not call name() on rpitit assoc_item) - rust-lang#141316 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2025
Rollup merge of rust-lang#141222 - mathisbot:ptr_trycastaligned, r=tgross35 Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`. Implement three common methods on raw pointers and `NonNull`s: `try_cast_aligned`. ## Related links - Tracking Issue: rust-lang#141221 ## About `#[inline]` Since the result of a call to `align_of` is a power of two known at compile time, the compiler is able to reduce a call to `try_cast_aligned` to only test and sete (or test and jne if followed by `unwrap`), at least on every tier 1 target's arch. This seemed like a good reason to `#[inline]` the function. - https://godbolt.org/z/ocehvPWMx (raw inlining) - https://godbolt.org/z/3qa4j4Yrn (comparison with no inlining)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 22, 2025
…rovenance, r=tgross35 try_cast_aligned: avoid bare int-to-ptr casts This fixes a CI failure in https://github.com/rust-lang/miri-test-libstd caused by strict provenance violations in doctests added in rust-lang#141222. r? `@tgross35` Cc `@mathisbot`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
Rollup merge of rust-lang#141381 - RalfJung:try_cast_aligned-strict-provenance, r=tgross35 try_cast_aligned: avoid bare int-to-ptr casts This fixes a CI failure in https://github.com/rust-lang/miri-test-libstd caused by strict provenance violations in doctests added in rust-lang#141222. r? `@tgross35` Cc `@mathisbot`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement three common methods on raw pointers and
NonNulls:try_cast_aligned.Related links
#![feature(pointer_try_cast_aligned)]#141221About
#[inline]Since the result of a call to
align_ofis a power of two known at compile time, the compiler is able to reduce a call totry_cast_alignedto only test and sete (or test and jne if followed byunwrap), at least on every tier 1 target's arch. This seemed like a good reason to#[inline]the function.