Skip to content

ci: split dist-arm-linux job #141078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented May 16, 2025

Split this job to use free runners instead of the large runner.
We could probably move this job to the ubuntu-arm runner, but we can do this further optimization later.

r? @Kobzol

try-job: dist-arm-linux-*

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 16, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
ci: split dist-arm-linux job

try-job: `dist-arm-linux-*`
@bors
Copy link
Collaborator

bors commented May 16, 2025

⌛ Trying commit 910730b with merge 989ccae...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 16, 2025

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 16, 2025
@marcoieni marcoieni force-pushed the split-dist-arm-linux branch from 910730b to b01f731 Compare May 16, 2025 13:51
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 16, 2025

⌛ Trying commit b01f731 with merge 3fd8bcd...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
ci: split dist-arm-linux job

try-job: `dist-arm-linux-*`
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 16, 2025

💔 Test failed - checks-actions

@marcoieni marcoieni force-pushed the split-dist-arm-linux branch from b01f731 to 133bb28 Compare May 18, 2025 09:26
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
ci: split dist-arm-linux job

try-job: `dist-arm-linux-*`
@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit 133bb28 with merge 761fc1f...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 18, 2025

💔 Test failed - checks-actions

@marcoieni marcoieni force-pushed the split-dist-arm-linux branch from 133bb28 to c2792b2 Compare May 18, 2025 10:12
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit c2792b2 with merge d423ef8...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
ci: split dist-arm-linux job

try-job: `dist-arm-linux-*`
@bors
Copy link
Collaborator

bors commented May 18, 2025

☀️ Try build successful - checks-actions
Build commit: d423ef8 (d423ef868ca4b92248ad4673569bc3dec30e216a)

@marcoieni
Copy link
Member Author

Timings look good
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from the other defconfig file

@marcoieni
Copy link
Member Author

For the reviewers, please compare how the dockerfiles changed wrt before. 🙏

@marcoieni marcoieni marked this pull request as ready for review May 18, 2025 14:47
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2025
@marcoieni
Copy link
Member Author

@rustbot ready

@Kobzol
Copy link
Contributor

Kobzol commented May 20, 2025

I think we already used the new ARM runners for this job for a while, but I don't remember why we switched back. In any case, keeping cross-compilation for now should be fine.

@Kobzol
Copy link
Contributor

Kobzol commented May 20, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented May 20, 2025

📌 Commit c2792b2 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#140981 (Add match guard let chain drop order and scoping tests)
 - rust-lang#141042 (ci: split powerpc64le-linux job)
 - rust-lang#141078 (ci: split dist-arm-linux job)
 - rust-lang#141222 (Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`.)
 - rust-lang#141308 (Do not call name() on rpitit assoc_item)
 - rust-lang#141316 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c592027 into rust-lang:master May 21, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 21, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
Rollup merge of rust-lang#141078 - marcoieni:split-dist-arm-linux, r=Kobzol

ci: split dist-arm-linux job

try-job: `dist-arm-linux-*`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants