Skip to content

Add bors environment to CI #141323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Add bors environment to CI #141323

merged 1 commit into from
May 22, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 21, 2025

This will be used to access secrets once we move off rust-lang-ci. The PR configures the environment:

  • Only for rust-lang/rust, so that it doesn't affect rust-lang-ci/rust before we switch (we can remove this condition later, but the environment likely won't work for forks anyway, so we might as well just keep it to make fork CI work)
  • Only for the try/auto branches, so that PR CI still works.

Context: rust-lang/infra-team#188

r? @marcoieni

@Kobzol Kobzol force-pushed the bors-environment branch 2 times, most recently from f7406db to 05766f2 Compare May 21, 2025 10:56
@Kobzol Kobzol marked this pull request as ready for review May 21, 2025 10:58
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented May 21, 2025

Ok I think that we can merge this as-is, it shouldn't break the current setup, but at the same time it should provide environment secrets to the try branch, so that we can manually test if CI works there in this repository.

@marcoieni
Copy link
Member

please comment the code to explain why we are doing this 👍

@Kobzol Kobzol force-pushed the bors-environment branch from 05766f2 to 004fd5a Compare May 21, 2025 11:09
This will be used to access secrets once we move off rust-lang-ci.
@Kobzol Kobzol force-pushed the bors-environment branch from 004fd5a to 78d3ea1 Compare May 21, 2025 11:10
@Kobzol
Copy link
Contributor Author

Kobzol commented May 21, 2025

Good idea, added a comment.

@marcoieni
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 21, 2025

📌 Commit 78d3ea1 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#140431 (dont handle bool transmute)
 - rust-lang#140868 (rustdoc: Fix links with inline code in trait impl docs)
 - rust-lang#141323 (Add bors environment to CI)
 - rust-lang#141337 (bump stdarch)
 - rust-lang#141364 (rustdoc-json: Remove false docs and add test for inline attribute)
 - rust-lang#141370 (add doc alias `replace_first` for `str::replacen`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6f58f30 into rust-lang:master May 22, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 22, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
Rollup merge of rust-lang#141323 - Kobzol:bors-environment, r=marcoieni

Add bors environment to CI

This will be used to access secrets once we move off rust-lang-ci. The PR configures the environment:
- Only for `rust-lang/rust`, so that it doesn't affect `rust-lang-ci/rust` before we switch (we can remove this condition later, but the environment likely won't work for forks anyway, so we might as well just keep it to make fork CI work)
- Only for the `try`/`auto` branches, so that PR CI still works.

Context: rust-lang/infra-team#188

r? `@marcoieni`
@Kobzol Kobzol deleted the bors-environment branch May 22, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants