Rollup of 6 pull requests #141320
Merged
Rollup of 6 pull requests #141320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on tests/ui/rfcs/rfc-2497-if-let-chains/temporary-early-drop.rs
…trochenkov Add match guard let chain drop order and scoping tests We have a bunch of tests for if let chain drop order, but those tests don't cover match guard chains to the same depth. This PR adds the following tests: * match guard equivalents of the if let chains tests in the `drop-order-comparisons.rs` test, added by rust-lang#133605. * match guard equivalent of the `mir_let_chains_drop_order.rs` test, added by rust-lang#107251 * match guard equivalent of `temporary-early-drop.rs`, added by rust-lang#133093 The added tests all have variants for 2021 and 2024, showing that the behavior on both editions matches that of if let chains on 2024. tracking issue: rust-lang#51114
…inux, r=Kobzol ci: split powerpc64le-linux job try-job: `dist-powerpc64le-linux-*`
…Kobzol ci: split dist-arm-linux job try-job: `dist-arm-linux-*`
…ross35 Implement `ptr::try_cast_aligned` and `NonNull::try_cast_aligned`. Implement three common methods on raw pointers and `NonNull`s: `try_cast_aligned`. ## Related links - Tracking Issue: rust-lang#141221 ## About `#[inline]` Since the result of a call to `align_of` is a power of two known at compile time, the compiler is able to reduce a call to `try_cast_aligned` to only test and sete (or test and jne if followed by `unwrap`), at least on every tier 1 target's arch. This seemed like a good reason to `#[inline]` the function. - https://godbolt.org/z/ocehvPWMx (raw inlining) - https://godbolt.org/z/3qa4j4Yrn (comparison with no inlining)
…ing-ice, r=nnethercote Do not call name() on rpitit assoc_item Fixes rust-lang#141143 r? `@nnethercote`
Update books ## rust-lang/edition-guide 1 commits in 1b1bb49babd65c732468cfa515b0c009bd1d26bc..aa6ce337c0adf7a63e33960d184270f2a45ab9ef 2025-05-20 23:47:34 UTC to 2025-05-20 23:47:34 UTC - Update references to the `missing_fragment_specifier` lint (rust-lang/edition-guide#376) ## rust-lang/reference 3 commits in acd0231ebc74849f6a8907b5e646ce86721aad76..118fd1f1f0854f50e3ae1fe4b64862aad23009ca 2025-05-20 22:52:38 UTC to 2025-05-20 21:45:13 UTC - Explain why nested receivers are dyn-incompatible (rust-lang/reference#1822) - Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot (rust-lang/reference#1788) - Mention the temporary scope of `while let`. (rust-lang/reference#1779)
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 87b4541569 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 87b4541 (parent) -> bbd3a5a (this PR) Test differencesShow 306 test diffsStage 1
Stage 2
Additionally, 294 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard bbd3a5ada41e0d4678de15d10404a4733dba4087 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Finished benchmarking commit (bbd3a5a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -3.9%, secondary -3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 775.275s -> 776.541s (0.16%) |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ptr::try_cast_alignedandNonNull::try_cast_aligned. #141222 (Implementptr::try_cast_alignedandNonNull::try_cast_aligned.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup