refactor(provider-acp-registry): move the ACP Registry into its own package

[juliusmarminge]

The ACP Registry was the last ACP flavor I could move without settling the model-manifest question (Antigravity is waiting on that). This moves it into @t3tools/provider-acp-registry, built on @t3tools/provider-acp.

Package

• ./settings: AcpRegistrySettings and AcpRegistryDistributionPreference, moved out of contracts.
• ./client: label, settings form, hasDefaultInstance: false, and the registry glyph clients show while an agent's own icon loads. Web and mobile both register it.
• ./server: AcpRegistryDriver, AcpRegistryAdapterV2Driver, and acpRegistryManagedBinaryDirectories, which the terminal manager uses to keep managed agents off PATH.
• ./server/AcpRegistrySupport and ./server/AcpRegistryRuntimeCoordinator: the catalog and coordinator services. Each has its own subpath and is imported as a namespace. AcpRegistrySupport.layerFromHost builds both from ProviderHost paths, which replaces the server's AcpRegistryCatalog.ts. Layers are top-level exports reached through the namespace, not static methods on the service class; a second commit makes the same change for AcpSessionRuntime and OpenCodeRuntimeError.is.
• ./testing: the adapter, probe, and Devin helpers the server's ACP tests use.

Boundaries

• The package reaches the server only through ProviderHost. Host settings gain withSnapshot, which the catalog uses to check whether an installed agent is still referenced before it deletes the agent. It's backed by ServerSettingsService.withSettingsSnapshot, so the check can't race a settings write.
• layerTestProviderHost now also provides TestProviderHostSettings, so tests can change settings mid-test. The catalog's uninstall tests use it in place of the real settings service.
• Two generic pieces moved to shared homes: PtyAdapter to @t3tools/shared, and ProviderAuthFlow to provider-core.
• The probe test stays in the server because it drives the server's ACP mock agent script.
• The package's tsconfig uses the server's lib (no DOM), which matches its Node runtime.
• @noble/hashes moves from the server to this package, its only user.

Verification

• Typecheck: provider-acp-registry, provider-core, provider-testing, shared, contracts, server, web, mobile.
• Tests: the package, plus the server's Registry adapter and probe, ACP adapter, terminal, provider registry, Codex ChatGPT auth, adapter registry, replay fixtures, and web settings and provider-icon tests. 1293 passed before the rebase. After rebasing onto current main I reran the Registry, terminal, and provider-registry tests, and those 204 passed.
• vp lint and knip pass on the changed workspaces.

Done by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a broad ACP Registry package extraction that also changes shared ProviderHost/service wiring, client registration, and authentication/session integration. The implementation is largely moved rather than rewritten, but the cross-package runtime and sensitive auth surface warrant focused human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	4.9 KiB	4.9 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.8 KiB	20.8 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	1	1	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	+24 B (+0.5%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+24 B (+2.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	+41 B (+0.2%)	29.3 KiB	✅
Claude	Live turn messages	1	2	+1 (+100.0%)	8	✅

Baseline: 563645c · PR result: 3770e65 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 1d7c0eb8-34c0-470b-aa3d-5031f8f6395b

📥 Commits

Reviewing files that changed from the base of the PR and between 8f8d18f and 3770e65.

📒 Files selected for processing (8)

• apps/server/src/provider/ProviderInstanceRegistryHydration.ts
• apps/server/src/server.ts
• packages/provider-acp-registry/src/server/AcpRegistryRuntimeCoordinator.test.ts
• packages/provider-acp-registry/src/server/AcpRegistryRuntimeCoordinator.ts
• packages/provider-acp-registry/src/server/AcpRegistrySupport.ts
• packages/provider-acp/src/server/AcpSessionRuntime.ts
• packages/provider-opencode/src/server/OpenCodeRuntime.ts
• packages/provider-opencode/src/server/v2/OpenCode2Server.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The ACP Registry provider code and settings schema now live in a dedicated workspace package with client, server, and testing entry points. Mobile, web, and server import the package. Server catalog construction uses ProviderHost settings snapshots, and shared ProviderAuthFlow and PtyAdapter APIs have package exports.

Changes

ACP Registry package extraction

Layer / File(s)	Summary
Package settings and public APIs packages/provider-acp-registry/*, packages/provider-core/package.json, packages/provider-core/src/server/ProviderAuthFlow.ts, packages/shared/package.json, packages/shared/src/PtyAdapter.ts, packages/contracts/src/settings.ts	The new package defines the ACP Registry settings schema and client, server, and testing entry points. The schema is removed from contracts. Provider core and shared packages expose ProviderAuthFlow and PtyAdapter APIs.
ProviderHost catalog integration packages/provider-core/src/server/ProviderHost.ts, packages/provider-core/src/server/managedProvider.test.ts, packages/provider-testing/src/host.ts, packages/provider-acp-registry/src/server/AcpRegistrySupport.ts, packages/provider-acp-registry/src/server/AcpRegistrySupport.test.ts, apps/server/src/provider/*, apps/server/src/server.ts	ProviderHost adds stable settings snapshots, and the test host adds mutable settings support. The ACP Registry catalog reads settings and host paths through ProviderHost. Server startup and registry hydration use the package catalog layer.
ACP Registry implementation and application wiring packages/provider-acp-registry/src/server/*, apps/mobile/*, apps/web/*, apps/server/src/orchestration-v2/*, apps/server/src/provider/*, apps/server/src/terminal/*, apps/server/src/ws.ts, packages/shared/src/PtyAdapter.ts, package.json, scripts/release-smoke.ts	ACP Registry server modules and tests use package-local settings and imports. Mobile and web register the package client. Server code imports package drivers, support, adapter helpers, and shared PtyAdapter. Workspace checks and the release smoke fixture include the package.

Provider runtime API updates

Layer / File(s)	Summary
OpenCode runtime error guard packages/provider-opencode/src/server/OpenCodeRuntime.ts, packages/provider-opencode/src/server/v2/OpenCode2Server.ts	OpenCode replaces the static runtime-error predicate with an exported type guard. Runtime error handling and server verification use the new guard.
ACP session runtime layer API packages/provider-acp/src/server/AcpSessionRuntime.ts	The ACP session runtime class no longer declares its static layer factory.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 3770e

No actionable merge-blocking issue is identified; the inspected catalog wiring supports merging after normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check		The description explains the package structure, architectural boundaries, and verification results. It does not provide the required Scope and approval information, and it does not explicitly separate…	Add a Scope and approval section with a linked issue or discussion and explicit maintainer approval, or explain why this focused refactor qualifies for an exemption. Add explicit Problem and Change sections that state the underlying problem…

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the primary change: moving the ACP Registry into its own package.

Full details: Description check

Explanation

The description explains the package structure, architectural boundaries, and verification results. It does not provide the required Scope and approval information, and it does not explicitly separate the Problem and Change sections.

Resolution

Add a Scope and approval section with a linked issue or discussion and explicit maintainer approval, or explain why this focused refactor qualifies for an exemption. Add explicit Problem and Change sections that state the underlying problem, expected behavior, and how the refactor addresses it. Keep the existing verification details and state any checks that remain incomplete after rebasing if applicable.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}