fix(server): keep newly discovered models out of legacy groups

[Bil0000]

What Changed

New models returned by a provider now stay in the main model list until the manifest explicitly marks them as legacy. The shared classifier clears stale legacy flags, keeps custom models unchanged, and preserves qualified Codex model IDs.

Add explicit legacy entries for the older Codex models so they remain in the legacy group.

Why

The fallback treated every model missing from currentModels as legacy. A new release could therefore appear under the collapsed “Legacy models” group even after discovery and polling worked correctly.

This fixes classification at the shared server boundary used by Codex and Antigravity, so web, desktop, and mobile receive the same result. It does not change native model discovery or proxy refresh behavior. Models require an explicit legacy status to enter the legacy group.

UI Changes

Captured from the real T3 web app with an isolated Codex catalog and fake local model data. No model requests were sent.

Before: the new test model appears under “Legacy models.”

After: it appears in the main list; the known old model stays under “Legacy models.”

Verification

• 79 focused tests passed on the current main base across model classification, both provider drivers, compatibility, and Codex installation. The regression tests failed before the original fix.
• Targeted formatting and lint passed. Server typecheck passed.
• Updated the Antigravity integration expectation so models absent from the manifest stay current.
• Real app: verified grouping before and after, then selected the new test model.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes

Model: GPT-6.1 Sol. Harness: Codex.

[macroscopeapp]

Approvability

Verdict: Approved at 547b175

Macroscope's review found this PR approvable — This is a small, well-tested server classification fix that keeps newly discovered models in the main list while explicitly preserving known legacy grouping. Its runtime impact is limited to model presentation and fallback selection, with no schema, discovery, deployment, or sensitive-code changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 05b259a2-67c9-4b18-ab09-3f9c04fbdc17

📥 Commits

Reviewing files that changed from the base of the PR and between b1e71c6 and c0d3a8f.

📒 Files selected for processing (3)

• apps/server/src/provider/Drivers/AntigravityDriver.test.ts
• apps/server/src/provider/ModelManifest.test.ts
• apps/server/src/provider/model-manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The provider manifest now lists five legacy Codex models. Model classification now marks a model as legacy only when its provider catalog entry explicitly has legacy status. Tests cover listed legacy models and unlisted models with stale legacy flags.

Changes

Legacy model classification

Layer / File(s)	Summary
Catalog entries and classification apps/server/src/provider/model-manifest.json, apps/server/src/provider/ModelManifest.ts, apps/server/src/provider/ModelManifest.test.ts, apps/server/src/provider/Drivers/AntigravityDriver.test.ts	The manifest adds five legacy Codex models. isLegacyModel now requires a matching catalog entry with status: "legacy". Tests cover known legacy models, unlisted models, and providers without a catalog.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to c0d3a

The changed classification keeps newly discovered models out of the legacy group while retaining explicit legacy entries. No concrete merge-blocking issue is established.

Architecture Summary

Architecture risk: 🔵 Low · up to c0d3a

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 4 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/provider/ModelManifest.ts: isLegacyModel now returns true only for a matched provider-catalog model with status "legacy". It removes the fallback that treated unmatched slugs and Codex families as legacy when absent from currentModels.
• observed — Modified behavior in apps/server/src/provider/Drivers/AntigravityDriver.test.ts: The test expectation changes from requiring every model to have isLegacy === true to requiring every model not to have isLegacy === true.
• observed — Modified behavior in apps/server/src/provider/ModelManifest.test.ts: The Codex manifest fixture now includes a provider catalog with gpt-old marked legacy; the test’s legacy classification input is therefore represented by catalog status rather than only the current-model list.
• observed — Modified behavior in apps/server/src/provider/ModelManifest.test.ts: The test now describes legacy classification in terms of known legacy models and adds an unlisted new-release model with a stale legacy flag; its expected flag is cleared. The manifest fixture adds a catalog marking old-model as legacy.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the primary server-side fix: newly discovered models remain outside legacy groups.
Description check	✅ Passed	The description explains the problem, change, scope, UI impact, screenshots, focused verification, and observed results. It is mostly complete against the template, although it does not use the exact …

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate 7bbcf9a

Dismissing prior approval to re-evaluate b1e71c6

Dismissing prior approval to re-evaluate b1e71c6

Dismissing prior approval to re-evaluate c0d3a8f

Dismissing prior approval to re-evaluate febae52

Dismissing prior approval to re-evaluate 547b175