Skip to content

test(desktop): expect JetBrains IDEs among remote editors - #17291

Merged
juliusmarminge merged 1 commit into
mainfrom
t3/fix-main-ci-failure
Oct 8, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3/fix-main-ci-failure

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Main CI fails on apps/desktop/src/ipc/methods/window.test.ts > "finds remote editors installed without PATH launchers". #17271 gave JetBrains IDEs a remote (jetbrains://gateway) scheme, so probeRemoteEditors now correctly detects an installed WebStorm, but the test still asserted it was excluded.

Flip the assertion to expect WebStorm. vp test run src/ipc/methods/window.test.ts passes (9/9).

Opus 5.5 via Claude Code in T3 Code.

🤖 Generated with Claude Code


Devin Review

#17271 made JetBrains IDEs remote-capable, so probeRemoteEditors now
detects an installed WebStorm. The test still asserted the old exclusion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 8, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 8, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 75adc10

Macroscope's review found this PR approvable — The PR changes only a single ignored desktop test assertion, so its impact is limited to test expectations and does not modify shipped product behavior. It also introduces no product-default or static-analysis suppression changes.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 8, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 8, 2026 19:39

Dismissing prior approval to re-evaluate 75adc10

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 342e4ea8-b362-4d26-98ca-ceb440d2c60e
📥 Commits

Reviewing files that changed from the base of the PR and between df616cc and 75adc10.

📒 Files selected for processing (1)
  • apps/desktop/src/ipc/methods/window.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The remote-editor discovery test now expects probeRemoteEditors to detect WebStorm installed in its application bundle.

Changes

Remote editor discovery

Layer / File(s) Summary
WebStorm discovery assertion
apps/desktop/src/ipc/methods/window.test.ts
The test now expects the discovered editors to include webstorm.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 75adc

This test expectation matches the WebStorm discovery behavior represented by its fixture. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the failing assertion, the related behavior change from #17271, the code change, and the focused test result. It does not use the template headings or provide a direct…
Title check ✅ Passed The title is concise, specific, and accurately describes the test change to expect JetBrains IDEs among remote editors.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge enabled auto-merge (squash) October 8, 2026 19:40
@juliusmarminge
juliusmarminge merged commit 740f591 into main Oct 8, 2026
32 of 33 checks passed
@juliusmarminge
juliusmarminge deleted the t3/fix-main-ci-failure branch October 8, 2026 19:41
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +24 B (+0.5%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +24 B (+2.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB +41 B (+0.2%) 29.3 KiB ✅
Claude Live turn messages 1 2 +1 (+100.0%) 8 ✅

Baseline: fd25c42 · PR result: 75adc10 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 9, 2026
## What's Changed
* fix(server): pairing tokens work on Node versions that cannot bind booleans by @chisewaguri in pingdotgg/t3code#16730
* fix(mobile): HTML pages in a thread no longer trap scrolling on Android by @SunkenInTime in pingdotgg/t3code#17211
* fix(web): centered scrollers no longer shift when the scrollbar appears by @maria-rcks in pingdotgg/t3code#17077
* fix(web): distinguish thread search matches from code tints by @Yash-Singh1 in pingdotgg/t3code#17263
* fix(server): Pi extension wakes get an owned continuation turn by @StiensWout in pingdotgg/t3code#17214
* fix(server): Pi discovers optional T3 tools on demand by @StiensWout in pingdotgg/t3code#17220
* fix(web): stack merge dialog closes as soon as you confirm by @flamboh in pingdotgg/t3code#17116
* fix(server): Pi editor dialogs prefill the answer composer by @StiensWout in pingdotgg/t3code#17206
* fix(desktop): generate valid User-Agent that follows RFC 9110 guidelines by @jztmanyl in pingdotgg/t3code#17264
* fix(server): Pi discovers workspace skills and commands by @StiensWout in pingdotgg/t3code#17190
* fix(mobile): preserve navigation after native swipe back by @juliusmarminge in pingdotgg/t3code#17268
* fix(server): keep newly discovered models out of legacy groups by @Bil0000 in pingdotgg/t3code#14314
* feat(editors): open remote projects in JetBrains IDEs over SSH by @juliusmarminge in pingdotgg/t3code#17271
* test(desktop): expect JetBrains IDEs among remote editors by @juliusmarminge in pingdotgg/t3code#17291
* fix(server): recognize authenticated GitHub Enterprise hosts by @alimek in pingdotgg/t3code#11059
* fix(connect): relay client updates itself and skips incompatible cloudflared by @juliusmarminge in pingdotgg/t3code#17275
* fix(shared): relay client install waits out a brief Windows file lock by @ScottN-PV in pingdotgg/t3code#16998
* fix(shared): release relay install locks on cancellation by @yashranaway in pingdotgg/t3code#10585
* chore(shared): bump managed cloudflared to 2026.10.0 by @bompus in pingdotgg/t3code#11184
* fix(shared): bound cloudflared download with 10-minute timeout by @kvnloo in pingdotgg/t3code#14139
* refactor(provider-core): add provider-core and provider-testing packages by @juliusmarminge in pingdotgg/t3code#17299
* refactor(settings): drop the legacy per-driver providers map by @juliusmarminge in pingdotgg/t3code#17300
* refactor(provider-pi): move Pi into its own provider package by @juliusmarminge in pingdotgg/t3code#17302
* feat(models): tell users when a CLI update unlocks a new model by @juliusmarminge in pingdotgg/t3code#17307
* fix(web): collapsed composer reserves room for wide send actions by @maria-rcks in pingdotgg/t3code#17016
* fix(muse): workflow subagents no longer stall on hidden approvals by @t3dotgg in pingdotgg/t3code#17329

## New Contributors
* @chisewaguri made their first contribution in pingdotgg/t3code#16730
* @jztmanyl made their first contribution in pingdotgg/t3code#17264
* @alimek made their first contribution in pingdotgg/t3code#11059
* @kvnloo made their first contribution in pingdotgg/t3code#14139

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261008.2833...v0.0.46-nightly.20261008.2849

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261008.2849
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 9, 2026
## What's Changed
* fix(server): pairing tokens work on Node versions that cannot bind booleans by @chisewaguri in pingdotgg/t3code#16730
* fix(mobile): HTML pages in a thread no longer trap scrolling on Android by @SunkenInTime in pingdotgg/t3code#17211
* fix(web): centered scrollers no longer shift when the scrollbar appears by @maria-rcks in pingdotgg/t3code#17077
* fix(web): distinguish thread search matches from code tints by @Yash-Singh1 in pingdotgg/t3code#17263
* fix(server): Pi extension wakes get an owned continuation turn by @StiensWout in pingdotgg/t3code#17214
* fix(server): Pi discovers optional T3 tools on demand by @StiensWout in pingdotgg/t3code#17220
* fix(web): stack merge dialog closes as soon as you confirm by @flamboh in pingdotgg/t3code#17116
* fix(server): Pi editor dialogs prefill the answer composer by @StiensWout in pingdotgg/t3code#17206
* fix(desktop): generate valid User-Agent that follows RFC 9110 guidelines by @jztmanyl in pingdotgg/t3code#17264
* fix(server): Pi discovers workspace skills and commands by @StiensWout in pingdotgg/t3code#17190
* fix(mobile): preserve navigation after native swipe back by @juliusmarminge in pingdotgg/t3code#17268
* fix(server): keep newly discovered models out of legacy groups by @Bil0000 in pingdotgg/t3code#14314
* feat(editors): open remote projects in JetBrains IDEs over SSH by @juliusmarminge in pingdotgg/t3code#17271
* test(desktop): expect JetBrains IDEs among remote editors by @juliusmarminge in pingdotgg/t3code#17291
* fix(server): recognize authenticated GitHub Enterprise hosts by @alimek in pingdotgg/t3code#11059
* fix(connect): relay client updates itself and skips incompatible cloudflared by @juliusmarminge in pingdotgg/t3code#17275
* fix(shared): relay client install waits out a brief Windows file lock by @ScottN-PV in pingdotgg/t3code#16998
* fix(shared): release relay install locks on cancellation by @yashranaway in pingdotgg/t3code#10585
* chore(shared): bump managed cloudflared to 2026.10.0 by @bompus in pingdotgg/t3code#11184
* fix(shared): bound cloudflared download with 10-minute timeout by @kvnloo in pingdotgg/t3code#14139
* refactor(provider-core): add provider-core and provider-testing packages by @juliusmarminge in pingdotgg/t3code#17299
* refactor(settings): drop the legacy per-driver providers map by @juliusmarminge in pingdotgg/t3code#17300
* refactor(provider-pi): move Pi into its own provider package by @juliusmarminge in pingdotgg/t3code#17302
* feat(models): tell users when a CLI update unlocks a new model by @juliusmarminge in pingdotgg/t3code#17307
* fix(web): collapsed composer reserves room for wide send actions by @maria-rcks in pingdotgg/t3code#17016
* fix(muse): workflow subagents no longer stall on hidden approvals by @t3dotgg in pingdotgg/t3code#17329

## New Contributors
* @chisewaguri made their first contribution in pingdotgg/t3code#16730
* @jztmanyl made their first contribution in pingdotgg/t3code#17264
* @alimek made their first contribution in pingdotgg/t3code#11059
* @kvnloo made their first contribution in pingdotgg/t3code#14139

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261008.2833...v0.0.46-nightly.20261008.2849

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261008.2849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant