fix(shared): bound cloudflared download with 10-minute timeout

[kvnloo]

Problem: cloudflared's downloadAsset ran httpClient.execute and response.arrayBuffer with no deadline. A wedged-but-alive endpoint (or a stalled drip) parked the relay-client install forever — same unbounded-wait family as the previously fixed codex/app-server request timeouts and the OAuth/relay-unlink CLI timeouts.

Fix: wrap both network hops in Effect.timeout(CLOUDFLARED_DOWNLOAD_TIMEOUT) (10 minutes, generous for a ~40MB binary). Expiry flows through the existing mapError into RelayClientInstallError{reason: "download_failed"}, so the install error contract is unchanged. 2 files, +59 lines.

Validation:

• New test fails a stalled download after the download timeout (TestClock + forkChild + never-responding HttpClient): FAILS on base (hangs to the 60s vitest timeout — the defect is literally a hang), passes with the fix.
• Full relayClient.test.ts: 6/6 green with fix. tsc --noEmit clean on packages/shared. vp fmt clean.

Authored with AI assistance (Muse, Meta's Muse Spark) under the contributor's direction. The contributor reviewed the diff and ran the focused tests before opening this PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 06dfc40e-9358-4749-a29a-54c7880ae92a

📥 Commits

Reviewing files that changed from the base of the PR and between 822e4f1 and 89f9bff.

📒 Files selected for processing (2)

• packages/shared/src/relayClient.test.ts
• packages/shared/src/relayClient.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

Cloudflared release asset requests and response body reads now time out after 10 minutes. A stalled-download test verifies that installation fails with the download_failed reason.

Changes

Cloudflared download timeout

Layer / File(s)	Summary
Apply and test download timeouts packages/shared/src/relayClient.ts, packages/shared/src/relayClient.test.ts	Release asset requests and response body reads time out after 10 minutes. The test uses a stalled HTTP client and advances the test clock by 11 minutes to verify the download_failed error.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 89f9b

The change is mergeable with normal checks. The new test covers a stalled request, though it does not verify a stalled body read.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description clearly explains the problem, implementation, preserved error contract, and verification results. It does not include the required Scope and approval information or explain why this fo…	Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused and obvious bug fix qualifies for the exception. Keep the existing verification details.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a 10-minute timeout to cloudflared downloads.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the problem, implementation, preserved error contract, and verification results. It does not include the required Scope and approval information or explain why this focused bug fix qualifies for the no-approval exception.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 89f9bff

Macroscope's review found this PR approvable — This is a focused bug fix that bounds both cloudflared download phases and preserves the existing installation error contract. The accompanying test covers stalled requests, while all unrelated runtime paths remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 822e4f1

[juliusmarminge]

Rebased onto main after #17275 (822e4f1). The test file was rewritten on main, so I ported your stalled-download test onto it using main's helpers. It passes with the timeout and hangs without it.

[juliusmarminge]

Rebased again onto main after #16998, #10585 and #11184 landed (89f9bff). The stalled-download test sits after the new Windows rename tests. I also dropped a duplicate Fiber import that main picked up when the other two PRs merged. The relay client suite passes (20 tests), and the timeout test still hangs without the fix.

Dismissing prior approval to re-evaluate 89f9bff