-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark dune as a non-build dependency #14266
Conversation
🌩️ opam-lint errors 943b688
☀️ Installability check (+0) |
d84fee3
to
2743e53
Compare
2743e53
to
a31350a
Compare
I'm not too sure what's wrong with the CI. Maybe the patch is too big?!
|
…{ *build *\}(.*)/\1\2\3/' **/opam
…) +& *build(.*\}.*)/\1\2/' **/opam
…)build & *(.*\}.*)/\1\2/' **/opam
a31350a
to
943b688
Compare
@ocaml/opam-repository we should now be vigilant to not merge PRs with |
Si tu veux mon opinion, ça fait un peu... has been. ocaml/opam-repository#14266
One possible fix for #14185
Accepting the merge this is going to be painful for a lot of users. I'm not really looking forward to this but I feel like we have only a few choices:
{build}
in opam itself to make it only rebuild on downgradesdune
and disable the affected versions (@diml would you know which versions are affected?)I'm basically rewording @AltGr's comment here (see ocaml/opam#3850 (comment)). See there and in the issue above for further context and discussions.
cc @avsm
Note: I'm going to cancel manually all the CI run for this PR so that it doesn't take all the CI time available