Package ppx_string_interpolation.1.0.0 #15480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Dec 7, 2019
| ] | ||
|
|
||
| depends: [ | ||
| "dune" {build} |
There was a problem hiding this comment.
Suggested change
| "dune" {build} | |
| "dune" {>= "1.5"} |
Dune should not be tagged as a build dependency (see #14266). Furthermore your dune-project file says this package requires at least dune 1.5
There was a problem hiding this comment.
Thanks, addressed.
kit-ty-kate
reviewed
Dec 7, 2019
| depends: [ | ||
| "dune" {build} | ||
| "ocaml" {>= "4.04.1"} | ||
| "ppxlib" {build} |
There was a problem hiding this comment.
Suggested change
| "ppxlib" {build} | |
| "ppxlib" |
This package seems to be used in a library. Libraries need to be rebuilt when one of their dependencies change
There was a problem hiding this comment.
Thanks, addressed.
kit-ty-kate
reviewed
Dec 7, 2019
| "dune" {build} | ||
| "ocaml" {>= "4.04.1"} | ||
| "ppxlib" {build} | ||
| "sedlex" {build} |
There was a problem hiding this comment.
Suggested change
| "sedlex" {build} | |
| "sedlex" |
This package seems to be used in a library. Libraries need to be rebuilt when one of their dependencies change
There was a problem hiding this comment.
Thanks, addressed.
ksromanov
force-pushed
the
add-pkg-ppx_string_interpolation
branch
from
4da79bc
to
fc31e73
Compare
|
Commit: 4da79bc @ksromanov has posted 3 contributions. ☀️ All lint checks passed 4da79bc
☀️ Installability check (+1)
|
kkazuo
reviewed
Dec 8, 2019
packages/ppx_string_interpolation/ppx_string_interpolation.1.0.0/opam
Outdated
Show resolved
Hide resolved
ksromanov
force-pushed
the
add-pkg-ppx_string_interpolation
branch
from
fc31e73
to
2e668fb
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppx_string_interpolation.1.0.0String interpolation PPX preprocessor