[new release] ppxlib (0.8.1)

[NathanReb]

Base library and tools for ppx rewriters

• Project page: https://github.com/ocaml-ppx/ppxlib
• Documentation: https://ocaml-ppx.github.io/ppxlib/

CHANGES:

Fixed

• Report errors according to the value of OCAML_ERROR_STYLE and
  OCAML_COLOR in the standalone driver (Set compiler's error-style and color through env vars in standalone mode ocaml-ppx/ppxlib#83, @NathanReb)

[NathanReb]

The revdep failure with cconv-ppx seems to be unrelated to this release as it appears the package tests are broken on 4.08 with older versions of ppxlib as well.

[camelus]

☀️ All lint checks passed f5dc59e

• These packages passed lint tests: ppxlib.0.8.1

---

☀️ Installability check (+1)

• new installable packages (1): ppxlib.0.8.1

[kit-ty-kate]

The revdep failure with cconv-ppx seems to be unrelated to this release as it appears the package tests are broken on 4.08 with older versions of ppxlib as well.

It is indeed unrelated. I've seen this error before

[NathanReb]

Thanks!

I fixed the ocaml version restriction for the tests and made dune a regular dependency.

[NathanReb]

Looks like the test don't work on 4.08, I'll disable them!

[XVilka]

There are a lot of errors on 4.06 as well.

[NathanReb]

I'm a bit puzzled about the 4.06 failures. I tried it locally on a fresh 4.06.1 switch and the tests passed.

[NathanReb]

I'm guessing it's due to the INSTALL_LOCAL, I'll take a look but I'm wondering if it's worth holding up the release for that.

[NathanReb]

Gentle ping @kit-ty-kate, is this an absolute no go or do you think that's okay?

Is there by any chance a way to disable test for a system compiler switch? Couldn't find one in the doc.

[kit-ty-kate]

I think that should ok but do you know why it's failing on the system switch? I'm running Camelus manually and it's good to go otherwise

[hannesm]

FWIW AFAICT ppxlib 0.8.0 compiled and tested ok on system switch (but I don't know anything about ppxlib -- it may as well be that there was a less extensive test suite back then) https://travis-ci.org/ocaml/opam-repository/builds/537812691?utm_source=github_status&utm_medium=notification

[kit-ty-kate]

Thanks!

[NathanReb]

The 4.06 system compiler build for 0.8.0 was successful because the tests weren't run since the ocaml version constraint was incorrect.

By fixing it in this PR we re-enabled them and therefore found out they weren't working with a system compiler switch.

We have our own ppx_expect in ppxlib which we use for testing since. I suspect there's an issue in the way it's set up. The issue seems to be tied to ocamlfind/findlib somehow as the #use "topfind";; statement isn't working as intended and the subsequent #require trigger errors in the toplevel.

I'm not yet super familiar with these parts but I'm going to have to look into findlib's internal for another project soon and I hope to kill two birds with one stone (I love birds so I wish to emphasize that no actual bird will be harmed in the process) and figure this out.

[hannesm]

@NathanReb thanks for your investigation! :) please excuse my noise above then