bigstringaf.0.5.2: Untag dune a build dependency #14501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this change necessary? Dune is just a build dependency, after all. |
|
The definition of a build dependency according to opam is that is does not need to rebuild the package if the dependency changed. Dune does not fit this definition anymore as it installs metadata files dependent of the current dune version. If one downgrade the dune version they can't read this metadata file anymore and will fail any builds requiring this package. (see pull requests linked above for more info) |
Merged
dhil
added a commit
to dhil/links
that referenced
this pull request
Aug 9, 2019
(Supposedly dune no longer satisfies the OPAM definition of a build-time dependency)[ocaml/opam-repository#14501 (comment)], hence we should make it a runtime dependency. This patch removes `build` tag from the `.opam`-files such that `dune` becomes a runtime dependency.
dhil
added a commit
to links-lang/links
that referenced
this pull request
Aug 9, 2019
[Supposedly dune no longer satisfies the OPAM definition of a build-time dependency](ocaml/opam-repository#14501 (comment)), hence we should make it a runtime dependency. This patch removes `build` tag from the `.opam`-files such that `dune` becomes a runtime dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14497 was merged in between #14266 and was missing the fix
cc @seliopou could you change that upstream?