Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package fix.20200131 #15769

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Conversation

fpottier
Copy link
Contributor

fix.20200131

Facilities for memoization and fixed points



🐫 Pull-request generated by opam-publish v2.0.2

@kit-ty-kate
Copy link
Member

Thanks! Could you return the fix upstream?

@kit-ty-kate kit-ty-kate merged commit 894dcf3 into ocaml:master Feb 1, 2020
@fpottier
Copy link
Contributor Author

fpottier commented Feb 1, 2020

Hi Kate, could you explain the fix? I think that dune is needed only to build fix but is not needed by someone who wishes to use fix. Am I wrong?

@kit-ty-kate
Copy link
Member

Hi Kate, could you explain the fix? I think that dune is needed only to build fix but is not needed by someone who wishes to use fix. Am I wrong?

It used to be the case but it's no longer the case since dune stores the version number of the dune binary used to install the package in a file dune later uses to extract metadata from. If somewhere down the line dune gets downgraded, dune will crash when trying to read the file it installed before.
Relevant issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants