Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ocplib-endian.1.1 #16142

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

chambart
Copy link
Contributor

@chambart chambart commented Apr 4, 2020

After, hum quite some time. I do release a new version of ocplib-endian.
The minimal OCaml version has been bumped to 4.02.3

@camelus
Copy link
Contributor

camelus commented Apr 4, 2020

Commit: ab26b86

A pull request by opam-seasoned @chambart.

☀️ All lint checks passed ab26b86
  • These packages passed lint tests: ocplib-endian.1.1

☀️ Installability check (+1)
  • new installable packages (1): ocplib-endian.1.1

@chambart
Copy link
Contributor Author

chambart commented Apr 4, 2020

There are two build failures. msgpack is a bad checksum, so completely unrelated, we can ignore it here.

But the other is more interesting. The sequence of installs for the test produced a situation where dune 2.4.0 was installed then ocplib-endian was installed because it was required by opam-depext. Then the package requested a dune version < 2 hence it downgraded to dune 1.11.4.

But ocplib-endian was installed by dune, which produced a dune-package file with (lang dune 2.4) which of course is rejected by dune 1.11.4.

Is there a way to tell dune to produce dune-package files with version that are not higher than the one in the dune-project file (hence corresponding to the version constraint on the package) ? Or dune should just not be a build only dependency ?

@chambart
Copy link
Contributor Author

chambart commented Apr 4, 2020

I just changed it to a non-build dependency. If this is the right solution then it will be ready, otherwise, let me know and I will change this.

@kit-ty-kate
Copy link
Member

Or dune should just not be a build only dependency ?

Yes. See #14266 and ocaml/dune#2147

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit 96fdbb2 into ocaml:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants