test: cleanup and simplify test-crypto-aes-wrap #56748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasnell
commented
Jan 24, 2025
jasnell
commented
- Add comment explaining purpose of the test
- Eliminate duplicative/extraneous buffer allocations
* Add comment explaining purpose of the test * Eliminate duplicative/extraneous buffer allocations
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jan 24, 2025
richardlau
approved these changes
Jan 24, 2025
jasnell
added
the
author ready
lpinca
approved these changes
Jan 24, 2025
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
jasnell
added
the
commit-queue-squash
lpinca
added
the
commit-queue
|
This makes me sad ... especially since a couple of the tests flaked and I'm just going to have to run them again. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
removed
the
commit-queue
|
Landed in ea7ab16 |
aduh95
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Add comment explaining purpose of the test * Eliminate duplicative/extraneous buffer allocations PR-URL: #56748 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Add comment explaining purpose of the test * Eliminate duplicative/extraneous buffer allocations PR-URL: #56748 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
hvanness
pushed a commit
to hvanness/node
that referenced
this pull request
Jan 30, 2025
* Add comment explaining purpose of the test * Eliminate duplicative/extraneous buffer allocations PR-URL: nodejs#56748 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Add comment explaining purpose of the test * Eliminate duplicative/extraneous buffer allocations PR-URL: #56748 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.